v1.18: quic: delay calling set_max_concurrent_uni_streams/set_receive…

…_window (backport of #904) (#968) quic: delay calling set_max_concurrent_uni_streams/set_receive_window (#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) Co-authored-by: Alessandro Decina <[email protected]>
anza-xyz · Apr 24, 2024 · c8b19b3 · c8b19b3
1 parent 8e9969c
commit c8b19b3
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/streamer/src/nonblocking/quic.rs b/streamer/src/nonblocking/quic.rs
@@ -345,16 +345,10 @@ fn handle_and_cache_new_connection(
         params.total_stake,
     ) as u64)
     {
-        connection.set_max_concurrent_uni_streams(max_uni_streams);
+        let remote_addr = connection.remote_address();
         let receive_window =
             compute_recieve_window(params.max_stake, params.min_stake, params.peer_type);
 
-        if let Ok(receive_window) = receive_window {
-            connection.set_receive_window(receive_window);
-        }
-
-        let remote_addr = connection.remote_address();
-
         debug!(
             "Peer type {:?}, total stake {}, max streams {} receive_window {:?} from peer {}",
             params.peer_type,
@@ -375,6 +369,12 @@ fn handle_and_cache_new_connection(
             )
         {
             drop(connection_table_l);
+
+            if let Ok(receive_window) = receive_window {
+                connection.set_receive_window(receive_window);
+            }
+            connection.set_max_concurrent_uni_streams(max_uni_streams);
+
             tokio::spawn(handle_connection(
                 connection,
                 remote_addr,