-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1: SIMD-0207: Raise block limit to 50M (backport of #4112) #4145
base: v2.1
Are you sure you want to change the base?
Conversation
Cherry-pick of 9e59baa has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -38,6 +38,7 @@ pub const MAX_BLOCK_UNITS: u64 = | |||
|
|||
#[cfg(test)] | |||
static_assertions::const_assert_eq!(MAX_BLOCK_UNITS, 48_000_000); | |||
pub const MAX_BLOCK_UNITS_SIMD_0207: u64 = 50_000_000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be behind #[feature("dev-only-context-utils")]
the only external place it's used is a test. though perhaps the test can simply be in this crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning on using this elsewhere in scheduler for a default configuration option. Would rather keep backport consistent with the original PR than change it here on something so minor.
Problem
Summary of Changes
Fixes #
This is an automatic backport of pull request #4112 done by [Mergify](https://mergify.com).