Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMD-0207: Raise block limit to 50M #4026

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Dec 9, 2024

Problem

Summary of Changes

  • Add feature to the feature set for raising block limits
  • Clean up old limit justification(s)
  • Add function to get new limits for SIMD-0207
  • Add feature-activation path for SIMD-0207

Fixes #

@apfitzge
Copy link
Author

apfitzge commented Dec 9, 2024

Small patch to raise limits for solana-foundation/solana-improvement-documents#207.

There are 34 lines of test, so "functional" patch is small, and I think should be backported so we can raise chain capacity slightly at a much earlier date.

@apfitzge apfitzge marked this pull request as ready for review December 10, 2024 16:04
tao-stones
tao-stones previously approved these changes Dec 10, 2024
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge force-pushed the raising_cu_limits branch 2 times, most recently from 1276135 to 4f3fefd Compare December 11, 2024 18:32
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

cost-model/src/block_cost_limits.rs Outdated Show resolved Hide resolved
@apfitzge apfitzge added v2.0 Backport to v2.0 branch v2.1 Backport to v2.1 branch labels Dec 11, 2024
Copy link

mergify bot commented Dec 11, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link

mergify bot commented Dec 11, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@apfitzge apfitzge merged commit ccb3cd3 into anza-xyz:master Dec 11, 2024
52 checks passed
@apfitzge apfitzge deleted the raising_cu_limits branch December 11, 2024 23:07
mergify bot pushed a commit that referenced this pull request Dec 11, 2024
(cherry picked from commit ccb3cd3)

# Conflicts:
#	cost-model/src/block_cost_limits.rs
#	runtime/src/bank.rs
#	runtime/src/bank/tests.rs
#	sdk/src/feature_set.rs
mergify bot pushed a commit that referenced this pull request Dec 11, 2024
(cherry picked from commit ccb3cd3)

# Conflicts:
#	cost-model/src/block_cost_limits.rs
#	runtime/src/bank.rs
#	sdk/feature-set/src/lib.rs
apfitzge added a commit to apfitzge/agave that referenced this pull request Dec 13, 2024
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
apfitzge added a commit to apfitzge/agave that referenced this pull request Dec 13, 2024
apfitzge added a commit that referenced this pull request Dec 16, 2024
* SIMD-0207: Raise block limit to 50M (#4026)

* Fix loading from snapshots/genesis
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
* SIMD-0207: Raise block limit to 50M (#4026)

* Fix loading from snapshots/genesis

(cherry picked from commit 9e59baa)

# Conflicts:
#	cost-model/src/block_cost_limits.rs
#	runtime/src/bank.rs
#	sdk/feature-set/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.0 Backport to v2.0 branch v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants