Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract ed25519-instructions crate #3330

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

kevinheavey
Copy link

Problem

solana_sdk::ed25519_instruction blocks ripping out solana_sdk::precompiles

Summary of Changes

  • Move to its own crate and re-export with deprecation notice. Call the new crate solana-ed25519-instructions because solana-ed25519-instruction is already taken by a community crate

@kevinheavey kevinheavey force-pushed the extract-ed25519-instruction branch from 419f4d4 to 4d1811f Compare October 29, 2024 09:31
@kevinheavey kevinheavey requested a review from febo October 30, 2024 11:55
@kevinheavey kevinheavey force-pushed the extract-ed25519-instruction branch from d18a45f to dd38585 Compare October 30, 2024 21:16
@kevinheavey kevinheavey force-pushed the extract-ed25519-instruction branch 2 times, most recently from b5e18b8 to a606a44 Compare November 7, 2024 12:09
@febo
Copy link

febo commented Nov 12, 2024

Look good – @yihau could we please accept the invite for the crate?

@yihau
Copy link
Member

yihau commented Nov 12, 2024

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 13, 2024
febo
febo previously approved these changes Nov 13, 2024
@kevinheavey kevinheavey force-pushed the extract-ed25519-instruction branch from 8213380 to e279e8e Compare November 13, 2024 17:10
@anza-team anza-team removed the automerge automerge Merge this Pull Request automatically once CI passes label Nov 13, 2024
@anza-team
Copy link
Collaborator

😱 New commits were pushed while the automerge label was present.

@kevinheavey kevinheavey requested a review from febo November 13, 2024 19:56
@febo febo merged commit 22e10c7 into anza-xyz:master Nov 13, 2024
53 checks passed
@joncinque
Copy link

Ah darn, I got to this too late -- since we're adding the secp256r1 precompile under the crate name solana-secp256r1-program, I was hoping to keep all the precompile crate names consistent.

Any objections to changing this to solana-ed25519-program? Since it contains the actual program logic, that seems to be a better name. I'll take care of the renaming. Thoughts?

@kevinheavey
Copy link
Author

Fine by me

@kevinheavey
Copy link
Author

Oh but there's already a crate by that name https://crates.io/crates/solana-ed25519-program/

@joncinque
Copy link

Yeah I noticed that -- since we already own it, and we'll be publishing a new major version, it should be safe, right?

@kevinheavey
Copy link
Author

Yeah I guess so as long as the old one has been discontinued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants