-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract ed25519-instructions crate #3330
Extract ed25519-instructions crate #3330
Conversation
419f4d4
to
4d1811f
Compare
d18a45f
to
dd38585
Compare
b5e18b8
to
a606a44
Compare
Look good – @yihau could we please accept the invite for the crate? |
✅ |
8213380
to
e279e8e
Compare
😱 New commits were pushed while the automerge label was present. |
Ah darn, I got to this too late -- since we're adding the secp256r1 precompile under the crate name Any objections to changing this to |
Fine by me |
Oh but there's already a crate by that name https://crates.io/crates/solana-ed25519-program/ |
Yeah I noticed that -- since we already own it, and we'll be publishing a new major version, it should be safe, right? |
Yeah I guess so as long as the old one has been discontinued |
Problem
solana_sdk::ed25519_instruction
blocks ripping outsolana_sdk::precompiles
Summary of Changes
solana-ed25519-instructions
becausesolana-ed25519-instruction
is already taken by a community crate