-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMD-0075: Precompile for Secp256r1 #3152
base: master
Are you sure you want to change the base?
Conversation
0f4876e
to
8f18340
Compare
8f18340
to
4c753ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I looked at just about everything except the actual cryptography. I saw @samkim-crypto self-requested review.
I spotted a handful of small nits, mostly around naming and semantics. Let me know what you think. Other than that nice work!
Got it, sounds good 👍 Reverted the new error and fixed the conflicts. I still have the p256 implementation from the first SIMD attempt and for purposes of benchmarking, so if you want to take a look at that just let me know. |
de987a0
to
fd7bbb6
Compare
d2cb4da
to
6b92a71
Compare
Problem
There currently isn't support for signature verification of signatures on the NIST-P256 curve (primary curve used by Passkeys). Motivation and details can be found in SIMD-0075
Summary of Changes
secp256r1
crate to avoid further bloat ofsolana_sdk