Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zk-sdk] Flatten out arguments for ciphertext validity proofs #1134

Merged
merged 2 commits into from
May 2, 2024

Conversation

samkim-crypto
Copy link

@samkim-crypto samkim-crypto commented May 1, 2024

Problem

In the ciphertext validity proofs, the argument variables to functions are grouped into tuples that are related to each other. It was done this way to tidy things up in the beginning, but it actually seems to make the syntax a lot more messy.

Summary of Changes

Flatten out the argument variables as was also done in #1084.

Fixes #

@samkim-crypto samkim-crypto marked this pull request as ready for review May 1, 2024 08:41
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (9403ca6) to head (33676f1).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1134     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         880      880             
  Lines      235665   235633     -32     
=========================================
- Hits       193716   193632     -84     
- Misses      41949    42001     +52     

@samkim-crypto samkim-crypto requested a review from joncinque May 1, 2024 11:58
joncinque
joncinque previously approved these changes May 1, 2024
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the micro-nit, the rest is great!

@samkim-crypto samkim-crypto merged commit 7fc1a47 into anza-xyz:master May 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants