[zk-sdk] Change FeeSigmaProof to PercentageWithCapProof
#1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and `PercentageEqualityProof`
samkim-crypto
force-pushed
the
zk-sdk-percentage-proof
branch
from
57c46a0 to
65ac74f
Compare
samkim-crypto
force-pushed
the
zk-sdk-percentage-proof
branch
from
65ac74f to
5c14383
Compare
samkim-crypto
changed the title
FeeSigmaProof to PercentageWithCap proofFeeSigmaProof to PercentageWithCapProof
samkim-crypto
force-pushed
the
zk-sdk-percentage-proof
branch
from
5c14383 to
f2bc2f6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
=========================================
Coverage 82.2% 82.2%
=========================================
Files 868 880 +12
Lines 234388 235573 +1185
=========================================
+ Hits 192668 193670 +1002
- Misses 41720 41903 +183 |
joncinque
approved these changes
Apr 30, 2024
| //! The protocol guarantees computational soundness (by the hardness of discrete log) and perfect | ||
| //! zero-knowledge in the random oracle model. | ||
| //! | ||
| //! [`ZK Token proof program`]: https://docs.solanalabs.com/runtime/zk-token-proof |
There was a problem hiding this comment.
I guess you'll go back through in future work to rename zk-token-proof to zk-proof, correct?
There was a problem hiding this comment.
Yep, those have to be updated. Will do on a follow-up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Given two Pedersen commitments, the
FeeSigmaProofcertifies that one encodes a percentage (with cap) of the number encodes in the other commitment. It does have applications to private transfers, but the name is unnecessarily specific to this application only. It makes sense to rename the type to something more general as proposed in #671.Summary of Changes
Rename
FeeSigmaProoftoPercentageWithCapProof.I made some changes to docs/comments, in the second commit e059946, but I ended up re-writing some of these in 6d72470 since the existing set of comments were a little confusing.
Another notable change is 72ac6ee, which flattens out the set of parameter variables to functions. I initially grouped parameters that were related to each other to make things neater, but I think it actually makes the syntax much more messy. I updated the parameters so that it is always [commitment] --> [opening] --> [amount] order. I wanted to make this change long time ago, but I did not want to break any downstream.
Fixes #