Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Redis from AnyCable #44

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Decouple Redis from AnyCable #44

merged 2 commits into from
Aug 13, 2024

Conversation

palkan
Copy link
Member

@palkan palkan commented Aug 13, 2024

Context

AnyCable no longer depends on Redis in production, so shouldn't we.

Changes

  • Decoupled Redis from AnyCable.broadcast_adapter (and removed all usages of the broadcast adapter)
  • Refactored Redis usage to be connection pool-friendly (i.e., #with_redis { |conn| ... } instead of #redis). Although we do not use a connection pool by default, some users might want to go that way.

@palkan palkan requested a review from Envek August 13, 2024 09:42
Copy link
Member

@Envek Envek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'm all for it 👍

Below are some nitpicks and suggestions to discuss (all are optional)

lib/graphql-anycable.rb Outdated Show resolved Hide resolved
lib/graphql/subscriptions/anycable_subscriptions.rb Outdated Show resolved Hide resolved
spec/redis_helper.rb Outdated Show resolved Hide resolved
spec/graphql/anycable_spec.rb Outdated Show resolved Hide resolved
lib/graphql-anycable.rb Show resolved Hide resolved
Copy link
Member Author

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Envek Thanks!

@palkan palkan merged commit 755ada5 into master Aug 13, 2024
6 checks passed
@palkan palkan deleted the feat/decouple-redis branch August 13, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants