Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings when calling GraphQL::AnyCable::Cleaner.clean #47

Open
utay opened this issue Oct 25, 2024 · 0 comments
Open

Deprecation warnings when calling GraphQL::AnyCable::Cleaner.clean #47

utay opened this issue Oct 25, 2024 · 0 comments

Comments

@utay
Copy link

utay commented Oct 25, 2024

Describe the bug

Since 1.3.0 and this change #44, when calling GraphQL::AnyCable::Cleaner.clean we get these warnings:

Usage of `GraphQL::AnyCable.redis` is deprecated. Instead of `GraphQL::AnyCable.redis.whatever` use `GraphQL::AnyCable.with_redis { |redis| redis.whatever }`

It seems like the cleaner is still using GraphQL::AnyCable.redis: https://github.com/anycable/graphql-anycable/blob/fae6f96bcf7a38fede85c6dfeeb394cce606b43b/lib/graphql/anycable/cleaner.rb#L67C9-L67C32

Steps to reproduce

Call GraphQL::AnyCable::Cleaner.clean

Expected behavior

No warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant