Drop handling of client-provided channel identifiers #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling * master: Switch to RubyGems Trusted publishing in CI release workflow [ci skip] add emergency actions TO README fix: consider redis_prefix in GraphQL::AnyCable::Cleaner add ability to set scan_count and added a little refactoring ability to fetch subscription stats use "around" instead "before" little refactoring add changes to README remove override redis_prefix and add an extra spec feat: Add configurable graphql redis_prefix Support empty operation name with redis.rb v5 (#34) Use arrays to fix deprecation warnings with redis gem 4.8 (#29) Use real Redis in tests instead of fakeredis gem (#32) Better `config.use_client_provided_uniq_id` deprecation (#27) Delay the deprecation warning of use_client_provided_uniq_id (#26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking change as clients will have to change their channel's
unsubscribedmethod (see release notes for version 1.1.0 for details).By SemVer we will have to bump version to 2.0, but I don't want to 😅