Use redis in tests instead of fakeredis #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envek
reviewed
May 2, 2023
spec/redis_helper.rb
Outdated
| # frozen_string_literal: true | ||
|
|
||
| def configure_test_redis_db | ||
| url = ENV.fetch("REDIS_URL", "redis://localhost:6379/6") # AnyCable uses Redis DB number 5 by default |
There was a problem hiding this comment.
redis://localhost:6379/*6* and AnyCable uses Redis DB number 5 by default? 🤔
Suggested change
| url = ENV.fetch("REDIS_URL", "redis://localhost:6379/6") # AnyCable uses Redis DB number 5 by default | |
| url = ENV.fetch("REDIS_URL", "redis://localhost:6379/5") # AnyCable uses Redis DB number 5 by default |
README.md
Outdated
Comment on lines
164
to
169
| 4. Pass redis-server URL to AnyCable using ENV variables | ||
|
|
||
| ```bash | ||
| REDIS_URL=redis://localhost:6379/5 bundle exec rspec | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Maybe move test-specific things to a different section, not to mix with general use configuration?
Envek
approved these changes
May 8, 2023
|
Thanks a lot! |
Envek
added a commit
to smasry/graphql-anycable
that referenced
this pull request
May 8, 2023
* origin/master: Use real Redis in tests instead of fakeredis gem (anycable#32)
Envek
pushed a commit
that referenced
this pull request
Aug 3, 2023
Envek
added a commit
that referenced
this pull request
May 7, 2024
…dling * master: Switch to RubyGems Trusted publishing in CI release workflow [ci skip] add emergency actions TO README fix: consider redis_prefix in GraphQL::AnyCable::Cleaner add ability to set scan_count and added a little refactoring ability to fetch subscription stats use "around" instead "before" little refactoring add changes to README remove override redis_prefix and add an extra spec feat: Add configurable graphql redis_prefix Support empty operation name with redis.rb v5 (#34) Use arrays to fix deprecation warnings with redis gem 4.8 (#29) Use real Redis in tests instead of fakeredis gem (#32) Better `config.use_client_provided_uniq_id` deprecation (#27) Delay the deprecation warning of use_client_provided_uniq_id (#26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: