Improve the readability of post-installation test results #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kanha-gupta |
antoninbas
reviewed
May 6, 2024
go.mod
Outdated
| @@ -22,6 +22,7 @@ require ( | |||
| github.com/containernetworking/plugins v1.1.1 | |||
| github.com/coreos/go-iptables v0.7.0 | |||
| github.com/davecgh/go-spew v1.1.1 | |||
| github.com/fatih/color v1.15.0 | |||
There was a problem hiding this comment.
maybe use the latest version directly (v1.16.0)?
go.mod
Outdated
| @@ -41,6 +42,7 @@ require ( | |||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 | |||
| github.com/onsi/ginkgo/v2 v2.17.2 | |||
| github.com/onsi/gomega v1.33.1 | |||
| github.com/pkg/errors v0.9.1 | |||
There was a problem hiding this comment.
This package is deprecated, but I assume this comes from one of our dependencies?
There was a problem hiding this comment.
removed, not sure how it was added by accident.
| if testContext.echoOtherNodePod == nil { | ||
| return fmt.Errorf("Skipping Inter-Node test because multiple Nodes are not available") | ||
| return fmt.Errorf("Inter-Node test requires multiple Nodes"), true |
There was a problem hiding this comment.
An alternative would be to define a custom error type for skipped tests, but I don't have a strong preference
luolanzone
reviewed
May 7, 2024
luolanzone
reviewed
May 7, 2024
* Test results will be displayed in green, red, and yellow to indicate success, failure, and skipped, respectively. * Show the total number of success, failure, and skipped tests in the end. * Return error if any test fails. Otherwise, it would be hard for automation tools to detect whether the check succeeds or not. Signed-off-by: Quan Tian <[email protected]>
tnqn
force-pushed
the
improve-post-installation
branch
from
58c26a6
to
5b2a1f5
Compare
antoninbas
approved these changes
May 7, 2024
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of success:
Example of failure: