Pre-installation testing framework #6278

kanha-gupta · 2024-05-01T09:33:49Z

Ref #6153
This PR enables the testing of cluster state before Antrea is installed so that Antrea can be installed seamlessly and hence referred to as Pre-installation tests.
command to conduct the test is antctl check cluster
This PR includes :

Testing framework
4 Tests
Workflow updated
A bit of structure refactor

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/cluster/test_checkCNIAvailability.go

pkg/antctl/raw/check/cluster/test_checkcontrolplaneavailability.go

pkg/antctl/raw/check/cluster/test_checkk8sversion.go

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-05-05T00:35:53Z

Hey mentors, I have pushed the changes :)

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/cluster/test_checkCNIExistence.go

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

pkg/antctl/raw/check/util.go

.github/workflows/kind.yml

pkg/antctl/raw/check/cluster/test_checkCNIExistence.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-05-06T20:19:06Z

Hey mentors, I have pushed changes.
Some points :

2 more functions from post installation framework have been moved to Utils for common use
Pre-installation nows deploys on a different namespace
Workflows naming have been changed. Please update if it is valid :)

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/util.go

pkg/antctl/raw/check/cluster/test_checkCNIExistence.go

pkg/antctl/raw/check/cluster/test_checkcontrolplaneavailability.go

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

Signed-off-by: Kanha gupta <[email protected]>

# Conflicts: # .github/workflows/kind.yml # pkg/antctl/raw/check/installation/command.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-05-07T20:31:06Z

Hey mentors, Taking the PR #6291 as a reference, I have improved the readability of Pre-installation tests. Since none of the current tests involves getting skipped in any condition, Skipped tests are not calculated right now.
Maybe we can implement the yellow logs for tests such as checkCNIExistence for various situations ?

pkg/antctl/raw/check/cluster/test_checkcontrolplaneavailability.go

pkg/antctl/raw/check/cluster/test_checkk8sversion.go

pkg/antctl/raw/check/cluster/test_checkcniexistence.go

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/cluster/test_checkcniexistence.go

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/util.go

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/cluster/test_checkk8sversion.go

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

pkg/antctl/raw/check/util.go

Signed-off-by: Kanha gupta <[email protected]>

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/cluster/test_checkcniexistence.go

pkg/antctl/raw/check/cluster/command.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-05-09T19:57:15Z

Hey mentors, I have pushed the latest review changes

antoninbas

only a few minor comments left for me

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/cluster/test_checkcniexistence.go

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

pkg/antctl/raw/check/cluster/test_checkcniexistence.go

pkg/antctl/raw/check/cluster/test_checkcontrolplaneavailability.go

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

kanha-gupta · 2024-05-10T21:38:11Z

Hey mentors, I have made changes :)

Signed-off-by: Kanha gupta <[email protected]>

pkg/antctl/raw/check/cluster/command.go

pkg/antctl/raw/check/cluster/test_checkcontrolplaneavailability.go

Signed-off-by: Kanha gupta <[email protected]>

# Conflicts: # pkg/antctl/raw/check/installation/command.go

kanha-gupta · 2024-05-11T05:44:58Z

Hey mentors, changes have been made :)

pkg/antctl/raw/check/cluster/command.go

Signed-off-by: Kanha gupta <[email protected]>

tnqn

LGTM

luolanzone

a few nits

pkg/antctl/raw/check/cluster/test_checkk8sversion.go

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

kanha-gupta · 2024-05-13T12:41:00Z

Changes are pushed :)

pkg/antctl/raw/check/cluster/test_checkovsloadable.go

Signed-off-by: Kanha gupta <[email protected]>

antoninbas · 2024-05-13T19:41:45Z

/skip-all

antoninbas · 2024-05-14T00:08:18Z

@kanha-gupta The CI job is failing for your new command:

[kind-kind] The kernel module openvswitch is not built-in. Running modprobe command to load the module.
[kind-kind] Test check-if-openvswitch-is-loadable failed: error executing modprobe command in Pod cluster-checker-7598f74654-6dbmz: error in stream: command terminated with exit code 1

I think you are missing a required security capability for your container:

          securityContext:
            capabilities:
              add:
                - SYS_MODULE

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-05-14T21:06:58Z

@kanha-gupta The CI job is failing for your new command:

[kind-kind] The kernel module openvswitch is not built-in. Running modprobe command to load the module.
[kind-kind] Test check-if-openvswitch-is-loadable failed: error executing modprobe command in Pod cluster-checker-7598f74654-6dbmz: error in stream: command terminated with exit code 1

I think you are missing a required security capability for your container:

          securityContext:
            capabilities:
              add:
                - SYS_MODULE

Thanks. Implemented this and the tests are successful now. is there any comprehensive docs/guide available which states the restrictions of github workflows and other CI/CD workflows ?
It would help in future :)

antoninbas · 2024-05-14T21:41:49Z

Thanks. Implemented this and the tests are successful now. is there any comprehensive docs/guide available which states the restrictions of github workflows and other CI/CD workflows ?
It would help in future :)

This issue had nothing to do with CI/CD. This capability is always required to load kernel modules.

The online documentation for Github workflows is pretty comprehensive if you need to lookup something.

antoninbas · 2024-05-14T21:43:15Z

/skip-all

kanha-gupta force-pushed the antrea-cluster-checks branch from 74306fd to ccd4743 Compare May 1, 2024 14:27

antoninbas reviewed May 1, 2024

View reviewed changes

kanha-gupta force-pushed the antrea-cluster-checks branch from ccd4743 to 9f76013 Compare May 4, 2024 23:49

Pre-installation testing framework

51316a3

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-cluster-checks branch from 9f76013 to 51316a3 Compare May 4, 2024 23:54

luolanzone reviewed May 6, 2024

View reviewed changes

rajnkamr reviewed May 6, 2024

View reviewed changes

.github/workflows/kind.yml Outdated Show resolved Hide resolved

rajnkamr reviewed May 6, 2024

View reviewed changes

pkg/antctl/raw/check/cluster/test_checkCNIExistence.go Outdated Show resolved Hide resolved

rajnkamr reviewed May 6, 2024

View reviewed changes

pkg/antctl/raw/check/cluster/test_checkCNIExistence.go Outdated Show resolved Hide resolved

Review 1 changes

e75118f

Signed-off-by: Kanha gupta <[email protected]>

antoninbas reviewed May 6, 2024

View reviewed changes

kanha-gupta added 3 commits May 7, 2024 03:48

Review 2 changes

93afe40

Signed-off-by: Kanha gupta <[email protected]>

Merge branch 'refs/heads/main' into antrea-cluster-checks

a2c4158

# Conflicts: # .github/workflows/kind.yml # pkg/antctl/raw/check/installation/command.go

Improve readability of results

1cf55f9

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-cluster-checks branch from b123bed to 1cf55f9 Compare May 7, 2024 20:27

antoninbas reviewed May 7, 2024

View reviewed changes

tnqn reviewed May 8, 2024

View reviewed changes

Review 3 changes

3087388

Signed-off-by: Kanha gupta <[email protected]>

antoninbas reviewed May 8, 2024

View reviewed changes

Review 4 changes

0a0801f

Signed-off-by: Kanha gupta <[email protected]>

antoninbas reviewed May 9, 2024

View reviewed changes

tnqn reviewed May 10, 2024

View reviewed changes

Review 5 changes

66f0fe0

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-cluster-checks branch from 888d39b to 66f0fe0 Compare May 11, 2024 02:57

tnqn reviewed May 11, 2024

View reviewed changes

kanha-gupta added 2 commits May 11, 2024 11:02

Review 6 changes

9e0141d

Signed-off-by: Kanha gupta <[email protected]>

Merge branch 'refs/heads/main' into antrea-cluster-checks

91caf7e

# Conflicts: # pkg/antctl/raw/check/installation/command.go

kanha-gupta force-pushed the antrea-cluster-checks branch from 5cb0435 to 1e51878 Compare May 11, 2024 05:43

tnqn reviewed May 11, 2024

View reviewed changes

pkg/antctl/raw/check/cluster/command.go Outdated Show resolved Hide resolved

merge main

7651313

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-cluster-checks branch from 1e51878 to 7651313 Compare May 12, 2024 06:15

tnqn previously approved these changes May 13, 2024

View reviewed changes

luolanzone reviewed May 13, 2024

View reviewed changes

kanha-gupta dismissed tnqn’s stale review via 850bb48 May 13, 2024 12:39

antoninbas reviewed May 13, 2024

View reviewed changes

pkg/antctl/raw/check/cluster/test_checkovsloadable.go Outdated Show resolved Hide resolved

few minor improvements

548a115

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-cluster-checks branch from 850bb48 to 548a115 Compare May 13, 2024 19:32

antoninbas previously approved these changes May 13, 2024

View reviewed changes

kanha-gupta dismissed antoninbas’s stale review via 45da300 May 14, 2024 19:15

Added container security capability

0f1d7e1

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-cluster-checks branch from 45da300 to 0f1d7e1 Compare May 14, 2024 19:29

Error handling for labels

01605a3

Signed-off-by: Kanha gupta <[email protected]>

antoninbas approved these changes May 14, 2024

View reviewed changes

antoninbas merged commit 3eb4d44 into antrea-io:main May 14, 2024
52 of 55 checks passed

antoninbas added the action/release-note Indicates a PR that should be included in release notes. label May 14, 2024

kanha-gupta deleted the antrea-cluster-checks branch May 17, 2024 14:02

luolanzone added this to the Antrea v2.1 release milestone Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pre-installation testing framework #6278

Pre-installation testing framework #6278

kanha-gupta commented May 1, 2024

kanha-gupta commented May 5, 2024

kanha-gupta commented May 6, 2024

kanha-gupta commented May 7, 2024 •

edited

Loading

kanha-gupta commented May 9, 2024

antoninbas left a comment

kanha-gupta commented May 10, 2024

kanha-gupta commented May 11, 2024

tnqn left a comment

luolanzone left a comment

kanha-gupta commented May 13, 2024

antoninbas commented May 13, 2024

antoninbas commented May 14, 2024

kanha-gupta commented May 14, 2024 •

edited

Loading

antoninbas commented May 14, 2024

antoninbas commented May 14, 2024

Pre-installation testing framework #6278

Pre-installation testing framework #6278

Conversation

kanha-gupta commented May 1, 2024

kanha-gupta commented May 5, 2024

kanha-gupta commented May 6, 2024

kanha-gupta commented May 7, 2024 • edited Loading

kanha-gupta commented May 9, 2024

antoninbas left a comment

Choose a reason for hiding this comment

kanha-gupta commented May 10, 2024

kanha-gupta commented May 11, 2024

tnqn left a comment

Choose a reason for hiding this comment

luolanzone left a comment

Choose a reason for hiding this comment

kanha-gupta commented May 13, 2024

antoninbas commented May 13, 2024

antoninbas commented May 14, 2024

kanha-gupta commented May 14, 2024 • edited Loading

antoninbas commented May 14, 2024

antoninbas commented May 14, 2024

kanha-gupta commented May 7, 2024 •

edited

Loading

kanha-gupta commented May 14, 2024 •

edited

Loading