Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang from v1.17 to v1.19 #4105

Closed
antoninbas opened this issue Aug 11, 2022 · 0 comments · Fixed by #4106
Closed

Update Golang from v1.17 to v1.19 #4105

antoninbas opened this issue Aug 11, 2022 · 0 comments · Fixed by #4106
Assignees
Labels
area/build-release Issues or PRs related to building and releasing kind/task Categorizes issue or PR as related to a routine task that needs to be performed

Comments

@antoninbas
Copy link
Contributor

Golang v1.17 is now end of life. As usual, we will update to the latest available version (v1.19), starting with Antrea v1.9.

@antoninbas antoninbas self-assigned this Aug 11, 2022
@antoninbas antoninbas added area/build-release Issues or PRs related to building and releasing kind/task Categorizes issue or PR as related to a routine task that needs to be performed labels Aug 11, 2022
@antoninbas antoninbas added this to the Antrea v1.9 release milestone Aug 11, 2022
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 11, 2022
Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 11, 2022
Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 11, 2022
Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 11, 2022
Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.
* we need to disable cgo whenever building the Octant plugin on
  Linux. Not quite sure how this is related to the Go version update:
  maybe some small change in "go build" to determine when to enable /
  disable cgo.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 11, 2022
Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.
* we need to disable cgo whenever building the Octant plugin on
  Linux. Not quite sure how this is related to the Go version update:
  maybe some small change in "go build" to determine when to enable /
  disable cgo.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 12, 2022
Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.
* we need to disable cgo whenever building the Octant plugin on
  Linux. Not quite sure how this is related to the Go version update:
  maybe some small change in "go build" to determine when to enable /
  disable cgo.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 23, 2022
Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.
* we need to disable cgo whenever building the Octant plugin on
  Linux. Not quite sure how this is related to the Go version update:
  maybe some small change in "go build" to determine when to enable /
  disable cgo.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 23, 2022
Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.
* we need to disable cgo whenever building the Octant plugin on
  Linux. Not quite sure how this is related to the Go version update:
  maybe some small change in "go build" to determine when to enable /
  disable cgo.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit that referenced this issue Aug 24, 2022
* Update Go to v1.19

Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.
* we need to disable cgo whenever building the Octant plugin on
  Linux. Not quite sure how this is related to the Go version update:
  maybe some small change in "go build" to determine when to enable /
  disable cgo.

Fixes #4105

Signed-off-by: Antonin Bas <[email protected]>

* Fix docker_update_base_windows.yml

Signed-off-by: Antonin Bas <[email protected]>
heanlan pushed a commit to heanlan/antrea that referenced this issue Mar 29, 2023
* Update Go to v1.19

Most notables changes:
* we remove all uses of the io/ioutil package, which has been deprecated
* gofmt now reformats doc comments (e.g., lists inside comment blocks),
  which is why some comments have been reformatted automatically
* the codegen image has been updated to kubernetes-1.24.0-build.1 to
  include the updated version of Go. "go get: no longer builds or
  installs packages in module-aware mode, so "go get" has been replaced
  with "go install" in the Dockerfile.
* we now use the version of Go from the root go.mod file when setting up
  Go in Github workflows. This will reduce the number of changes we have
  to do in the future when updating Go.
* running "go mod tidy" with the updated Go version seems to have
  removed some stale entries from go.sum files.
* we need to disable cgo whenever building the Octant plugin on
  Linux. Not quite sure how this is related to the Go version update:
  maybe some small change in "go build" to determine when to enable /
  disable cgo.

Fixes antrea-io#4105

Signed-off-by: Antonin Bas <[email protected]>

* Fix docker_update_base_windows.yml

Signed-off-by: Antonin Bas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release Issues or PRs related to building and releasing kind/task Categorizes issue or PR as related to a routine task that needs to be performed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant