Update Go to v1.19

Most notables changes: * we remove all uses of the io/ioutil package, which has been deprecated * gofmt now reformats doc comments (e.g., lists inside comment blocks), which is why some comments have been reformatted automatically * the codegen image has been updated to kubernetes-1.24.0-build.1 to include the updated version of Go. "go get: no longer builds or installs packages in module-aware mode, so "go get" has been replaced with "go install" in the Dockerfile. * we now use the version of Go from the root go.mod file when setting up Go in Github workflows. This will reduce the number of changes we have to do in the future when updating Go. * running "go mod tidy" with the updated Go version seems to have removed some stale entries from go.sum files. * we need to disable cgo whenever building the Octant plugin on Linux. Not quite sure how this is related to the Go version update: maybe some small change in "go build" to determine when to enable / disable cgo. Fixes antrea-io#4105 Signed-off-by: Antonin Bas <[email protected]>
antoninbas · Aug 11, 2022 · 1927878 · 1927878
1 parent 173ef52
commit 1927878
Show file tree

Hide file tree

Showing 99 changed files with 453 additions and 754 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -10,16 +10,16 @@ jobs:
     name: GoBenchmark
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go 1.17
-        uses: actions/setup-go@v3
-        with:
-          go-version: 1.17
-
       - name: Check out code into the Go module directory
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
+      - name: Set up Go using version from go.mod
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
+
       - name: Install benchci
         run: curl -sfL https://raw.githubusercontent.com/antrea-io/benchci/main/install.sh | sudo sh -s -- -b /usr/local/bin
 

diff --git a/.github/workflows/clair.yml b/.github/workflows/clair.yml
@@ -13,7 +13,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-go@v3
       with:
-        go-version: 1.17
+        go-version-file: 'go.mod'
     - name: Scan Antrea Docker image for vulnerabilities
       env:
         AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID_SES }}

diff --git a/.github/workflows/dependabot.yml b/.github/workflows/dependabot.yml
@@ -31,15 +31,15 @@ jobs:
     if: ${{ github.actor == 'dependabot[bot]' && contains(github.event.pull_request.labels.*.name, 'dependencies') && contains(github.event.pull_request.labels.*.name, 'go') }}
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.17
     - uses: actions/checkout@v3
       with:
         # Check out the pull request HEAD
         ref: ${{ github.event.pull_request.head.sha }}
         token: ${{ secrets.ANTREA_BOT_WRITE_PAT }}
+    - name: Set up Go using version from go.mod
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: 'go.mod'
     - name: Run go mod tidy
       # the checks above (Github actor and PR labels) ensure that a malicious
       # actor cannot open a PR with a modified "tidy" Makefile target and

diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -38,12 +38,12 @@ jobs:
     name: Unit test (ubuntu-latest)
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.17
     - name: Check-out code
       uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: 'go.mod'
     - uses: actions/cache@v3
       with:
         # In order:
@@ -74,12 +74,12 @@ jobs:
     name: Unit test (windows-2019)
     runs-on: [windows-2019]
     steps:
-      - name: Set up Go 1.17
-        uses: actions/setup-go@v3
-        with:
-          go-version: 1.17
       - name: Check-out code
         uses: actions/checkout@v3
+      - name: Set up Go using version from go.mod
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
       - uses: actions/cache@v3
         with:
           # In order:
@@ -110,12 +110,12 @@ jobs:
     name: Integration test
     runs-on: [ubuntu-latest]
     steps:
-      - name: Set up Go 1.17
-        uses: actions/setup-go@v3
-        with:
-          go-version: 1.17
       - name: Check-out code
         uses: actions/checkout@v3
+      - name: Set up Go using version from go.mod
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
       - uses: actions/cache@v3
         with:
           # In order:
@@ -155,12 +155,12 @@ jobs:
     name: Golangci-lint (ubuntu-latest)
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.17
     - name: Check-out code
       uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: 'go.mod'
     - uses: actions/cache@v3
       with:
         # In order:
@@ -187,12 +187,12 @@ jobs:
     name: Golangci-lint (macos-latest)
     runs-on: [macos-latest]
     steps:
-      - name: Set up Go 1.17
-        uses: actions/setup-go@v3
-        with:
-          go-version: 1.17
       - name: Check-out code
         uses: actions/checkout@v3
+      - name: Set up Go using version from go.mod
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
       - uses: actions/cache@v3
         with:
           # In order:
@@ -219,12 +219,12 @@ jobs:
     name: Build Antrea and antctl binaries
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.17
     - name: Check-out code
       uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: 'go.mod'
     - uses: actions/cache@v3
       with:
         # In order:
@@ -258,12 +258,12 @@ jobs:
     name: Build Antrea Windows binaries
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.17
     - name: Check-out code
       uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: 'go.mod'
     - uses: actions/cache@v3
       with:
         # In order:
@@ -287,12 +287,12 @@ jobs:
     name: Check tidy, code generation and manifest
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.17
     - name: Check-out code
       uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: 'go.mod'
     # tidy check need to be run before code generation which will regenerate codes.
     - name: Check tidy
       run: make test-tidy
@@ -307,12 +307,12 @@ jobs:
     name: Verify docs and spelling
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.17
     - name: Check-out code
       uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: 'go.mod'
     - name: Run verify scripts
       run: make verify
     - name: Checking for broken Markdown links
@@ -343,11 +343,11 @@ jobs:
     name: Go benchmark test
     runs-on: [ubuntu-latest]
     steps:
-      - name: Set up Go 1.17
-        uses: actions/setup-go@v3
-        with:
-          go-version: 1.17
       - name: Check-out code
         uses: actions/checkout@v3
+      - name: Set up Go using version from go.mod
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
       - name: Run Go benchmark test
         run: go test -run '^$' -bench . -benchtime 1x -timeout 10m -cpu 4 -v -benchmem ./pkg/...
diff --git a/.github/workflows/golicense.yml b/.github/workflows/golicense.yml
@@ -33,11 +33,11 @@ jobs:
     if: ${{ needs.check-changes.outputs.has_changes == 'yes' || github.event_name != 'pull_request' }}
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
+    - uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
       uses: actions/setup-go@v3
       with:
-        go-version: 1.17
-    - uses: actions/checkout@v3
+        go-version-file: 'go.mod'
     - name: Cache licensing information for dependencies
       uses: actions/cache@v3
       id: cache

diff --git a/.github/workflows/kind.yml b/.github/workflows/kind.yml
@@ -78,7 +78,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-go@v3
       with:
-        go-version: 1.17
+        go-version-file: 'go.mod'
     - name: Download Antrea image from previous job
       uses: actions/download-artifact@v3
       with:
@@ -136,7 +136,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-go@v3
       with:
-        go-version: 1.17
+        go-version-file: 'go.mod'
     - name: Download Antrea image from previous job
       uses: actions/download-artifact@v3
       with:
@@ -194,7 +194,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version-file: 'go.mod'
       - name: Download Antrea image from previous job
         uses: actions/download-artifact@v3
         with:
@@ -253,7 +253,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-go@v3
       with:
-        go-version: 1.17
+        go-version-file: 'go.mod'
     - name: Download Antrea image from previous job
       uses: actions/download-artifact@v3
       with:
@@ -311,7 +311,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-go@v3
       with:
-        go-version: 1.17
+        go-version-file: 'go.mod'
     - name: Download Antrea image from previous job
       uses: actions/download-artifact@v3
       with:
@@ -369,7 +369,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version-file: 'go.mod'
       - name: Download Antrea image from previous job
         uses: actions/download-artifact@v3
         with:
@@ -434,7 +434,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version-file: 'go.mod'
       - name: Download Antrea image from previous job
         uses: actions/download-artifact@v3
         with:
@@ -477,7 +477,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version-file: 'go.mod'
       - name: Download Antrea image from previous job
         uses: actions/download-artifact@v3
         with:
@@ -520,7 +520,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version-file: 'go.mod'
       - name: Download Antrea image from previous job
         uses: actions/download-artifact@v3
         with:
@@ -563,7 +563,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version-file: 'go.mod'
       - name: Download Antrea image from previous job
         uses: actions/download-artifact@v3
         with:
@@ -606,7 +606,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-go@v3
       with:
-        go-version: 1.17
+        go-version-file: 'go.mod'
     - name: Download Antrea image from previous job
       uses: actions/download-artifact@v3
       with:
@@ -641,7 +641,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version-file: 'go.mod'
       - name: Download Antrea image from previous job
         uses: actions/download-artifact@v3
         with:

diff --git a/.github/workflows/process_release.yml b/.github/workflows/process_release.yml
@@ -8,11 +8,11 @@ jobs:
   upload-release-assets:
     runs-on: ubuntu-latest
     steps:
-    - name: Set up Go 1.17
+    - uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
       uses: actions/setup-go@v3
       with:
-        go-version: 1.17
-    - uses: actions/checkout@v3
+        go-version-file: 'go.mod'
     - name: Build assets
       env:
         TAG: ${{ github.ref }}

diff --git a/.github/workflows/verify_docs.yml b/.github/workflows/verify_docs.yml
@@ -10,12 +10,12 @@ jobs:
     name: Verify docs and spelling
     runs-on: [ubuntu-latest]
     steps:
-    - name: Set up Go 1.17
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.17
     - name: Check-out code
       uses: actions/checkout@v3
+    - name: Set up Go using version from go.mod
+      uses: actions/setup-go@v3
+      with:
+        go-version-file: 'go.mod'
     - name: Run verify scripts
       run: make verify
     - name: Checking for broken Markdown links for main branch

diff --git a/.golangci.yml b/.golangci.yml
@@ -13,12 +13,13 @@ linters-settings:
     ignore-generated-header: false
     severity: warning
     confidence: 0.8
+    # errorf, var-declaration temporarily disabled because of https://github.com/golangci/golangci-lint/issues/2997
     rules:
       - name: unreachable-code
-      - name: errorf
+      # - name: errorf
       - name: range
       - name: superfluous-else
-      - name: var-declaration
+      # - name: var-declaration
 
 linters:
   disable-all: true

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -247,7 +247,7 @@ the `$GOPATH`.
 
 To develop locally, you can follow these steps:
 
- 1. [Install Go 1.17](https://golang.org/doc/install)
+ 1. [Install Go 1.19](https://golang.org/doc/install)
  2. Checkout your feature branch and `cd` into it.
  3. To build all Go files and install them under `bin`, run `make bin`
  4. To run all Go unit tests, run `make test-unit`