Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DComponent creation refactoring. #894

Merged
merged 3 commits into from
Feb 25, 2022
Merged

3DComponent creation refactoring. #894

merged 3 commits into from
Feb 25, 2022

Conversation

Samuelopez-ansys
Copy link
Member

Now users could define specific Objets, CS, boundaries, and excitations from the HFSS Design. By default, it will export all the objects/boundaries available in the Design

…cts, CS, boundaries and excitations from the HFSS Design. By default, it will export all the objects/boundaries available in the Design
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #894 (986ff01) into main (75c6236) will increase coverage by 0.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   78.97%   79.46%   +0.49%     
==========================================
  Files         128      128              
  Lines       35642    35884     +242     
==========================================
+ Hits        28147    28516     +369     
+ Misses       7495     7368     -127     

@seeyouatcloudbase seeyouatcloudbase linked an issue Feb 25, 2022 that may be closed by this pull request
…cts, CS, boundaries and excitations from the HFSS Design. By default, it will export all the objects/boundaries available in the Design
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys removed the request for review from MaxJPRey February 25, 2022 13:27
@Samuelopez-ansys
Copy link
Member Author

@maxcapodi78 , @MaxJPRey do you know why is Style Check failing? Thanks

@maxcapodi78 maxcapodi78 merged commit 7ae1d07 into main Feb 25, 2022
@maxcapodi78 maxcapodi78 deleted the fix_issue891 branch February 25, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create 3DComponent method issue with CS
2 participants