AAP-21329: Capture relevant model in feedback events #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
romartin
requested review from
ganeshrn and
TamiTakamiya
and removed request for
priyamsahoo and
shatakshiiii
|
@TamiTakamiya @ganeshrn Working on the test case, but are failing for me locally, still looking... |
|
@ganeshrn @TamiTakamiya test case added as well. Ready for review, please. Thanks!! |
goneri
reviewed
Mar 14, 2024
goneri
approved these changes
Mar 15, 2024
ganeshrn
approved these changes
Mar 18, 2024
ganeshrn
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.redhat.com/browse/AAP-21329
This PR just send the model value from settings, if set, on the feedback requests. This way, given this another PR ansible/ansible-ai-connect-service#874, this information will flow into the wisdom's telemetry events.