AAP-21329: Capture relevant model in feedback events (#1131)

* AAP-21329: Capture relevant model in feedback events * Test case added * Reduced complexity --------- Co-authored-by: Ganesh Nalawade <[email protected]>
ansible · Mar 18, 2024 · 243ebeb · 243ebeb
1 parent aeecbf9
commit 243ebeb
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/src/features/lightspeed/api.ts b/src/features/lightspeed/api.ts
@@ -21,6 +21,7 @@ import { getBaseUri } from "./utils/webUtils";
 import { ANSIBLE_LIGHTSPEED_API_TIMEOUT } from "../../definitions/constants";
 import { UserAction } from "../../definitions/lightspeed";
 import { retrieveError } from "./handleApiError";
+import { lightSpeedManager } from "../../extension";
 
 export class LightSpeedAPI {
   private axiosInstance: AxiosInstance | undefined;
@@ -176,6 +177,9 @@ export class LightSpeedAPI {
     }
     const rhUserHasSeat = await this.lightSpeedAuthProvider.rhUserHasSeat();
 
+    inputData.model =
+      lightSpeedManager.settingsManager.settings.lightSpeedService.model;
+
     if (rhUserHasSeat && orgOptOutTelemetry) {
       if (inputData.inlineSuggestion) {
         delete inputData.inlineSuggestion;

diff --git a/src/interfaces/lightspeed.ts b/src/interfaces/lightspeed.ts
@@ -74,6 +74,7 @@ export interface FeedbackRequestParams {
   sentimentFeedback?: SentimentEvent;
   suggestionQualityFeedback?: SuggestionQualityEvent;
   issueFeedback?: IssueFeedbackEvent;
+  model?: string;
 }
 
 export interface IDocumentTrackerFields {

diff --git a/test/testScripts/lightspeed/testLightSpeedFunctions.test.ts b/test/testScripts/lightspeed/testLightSpeedFunctions.test.ts
@@ -123,6 +123,22 @@ function testFeedbackAPI(): void {
       // When an error is found, feedbackRequest() does not return a message
       assert.equal(response.message, undefined);
     });
+
+    it("Verify a sentiment feedback contains the model, if set", async function () {
+      lightSpeedManager.settingsManager.settings.lightSpeedService.model =
+        "testModel";
+      const apiInstance = lightSpeedManager.apiInstance;
+      const request = {
+        sentimentFeedback: {
+          value: 1,
+          feedback: "Great stuff",
+        },
+        model: "",
+      };
+      const response = await apiInstance.feedbackRequest(request);
+      console.log(JSON.stringify(response));
+      assert.equal(request.model, "testModel");
+    });
   });
 
   after(async function () {