Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Add more tests for tags #237

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Add more tests for tags #237

merged 2 commits into from
Apr 13, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Apr 13, 2022

More tests for #236

x
# Conflicts:
#	f/ansible.json
#	test/playbooks/tasks/tags.yml
@ssbarnea ssbarnea requested a review from a team as a code owner April 13, 2022 16:37
@ssbarnea
Copy link
Member Author

@MarkusTeufelberger Next time we need negative tests.

@MarkusTeufelberger
Copy link
Contributor

These might also be worth it:

Playbooks:

- name: Array with members but not string
  hosts: localhost
  tags:
    - 123 # <-- not allowed

Tasks:

- name: Array with members but not string
  ansible.builtin.debug:
    msg: foo
  tags:
    - 123 # <-- not allowed

@ssbarnea
Copy link
Member Author

We can do this after we remove the old schemas via #239 as I do not fancy updating 3 files instead of one.

@ssbarnea ssbarnea merged commit 61a0ad9 into ansible:main Apr 13, 2022
@ssbarnea ssbarnea deleted the fix/more-tests branch April 13, 2022 17:14
@MarkusTeufelberger
Copy link
Contributor

...these tests already do not pass (correctly), there would be no change necessary other than adding them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants