This repository has been archived by the owner on Dec 2, 2022. It is now read-only.
tags can be either string or list of strings #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Teufelberger <[email protected]>
|
That file is pending deprecation as the new one already got the fix, but we did not switch to it yet. I also added some tests to your change. |
ssbarnea
approved these changes
Apr 13, 2022
ssbarnea
changed the title
|
https://github.com/ansible/schemas/issues/207#issuecomment-1095216114 sounded like this might still be on hold. Lines 590 to 596 in 3da010f |
added 3 commits
April 13, 2022 16:48
Signed-off-by: Markus Teufelberger <[email protected]>
Signed-off-by: Markus Teufelberger <[email protected]>
Signed-off-by: Markus Teufelberger <[email protected]>
|
Alright, should be done + tested now, Ready for squashing and merging. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this was an oversight?
There are also "array-only"
tagsdefinitions in ansible-meta, ansible-lint and ansible-galaxy. These might also be "string OR array-of-strings" type, but I didn't check or verify those.