Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect ctx cancel #780

Merged
merged 1 commit into from
May 19, 2023
Merged

Respect ctx cancel #780

merged 1 commit into from
May 19, 2023

Commits on May 10, 2023

  1. Respect ctx cancel 

    I think there's a race condition between controller and receptor

controller see the job finished and try to cancel workunit

receptor does not respect the cancel and continue to do GET to kube apiserver with a dead ctx which cause a very misleading error message
```
client rate limiter Wait returned an error: context canceled
```
    @TheRealHaoLiu @shanemcd
    TheRealHaoLiu authored and shanemcd committed May 10, 2023
    Configuration menu
    Copy the full SHA
    9e19a84 View commit details
    Browse the repository at this point in the history