Respect ctx cancel #780
Merged
Respect ctx cancel #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there's a race condition between controller and receptor controller see the job finished and try to cancel workunit receptor does not respect the cancel and continue to do GET to kube apiserver with a dead ctx which cause a very misleading error message ``` client rate limiter Wait returned an error: context canceled ```
shanemcd
force-pushed
the
respect-ctx-cancel
branch
from
820264e
to
9e19a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a race condition between controller and receptor
controller see the job finished and try to cancel workunit
receptor does not respect the cancel and continue to do GET to kube apiserver with a dead ctx which cause a very misleading error message