-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Go action failures when artifact already exists #1053
Merged
thom-at-redhat
merged 7 commits into
ansible:devel
from
thom-at-redhat:fix_upload_artifact
May 30, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c5933d6
Fix Go action failures when artifact already exists
thom-at-redhat 0f7ca8e
Fix typo
thom-at-redhat 72f1747
Fix second typo
thom-at-redhat 4ea14bc
Reduce yamllint messages
thom-at-redhat eba6f89
Add go version to reusable_nox
thom-at-redhat b4dcbc1
Fix go version typo
thom-at-redhat 2eda9e3
Retest of codecov
thom-at-redhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
--- | ||
version: 2 | ||
updates: | ||
- package-ecosystem: gomod | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
--- | ||
needs_triage: | ||
- '.*' | ||
... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
name: Publish devel image | ||
|
||
on: | ||
on: # yamllint disable-line rule:truthy | ||
push: | ||
branches: [devel] | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
name: Publish nightly wheel | ||
|
||
on: | ||
on: # yamllint disable-line rule:truthy | ||
push: | ||
branches: [devel] | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
--- | ||
name: Promote Release | ||
on: | ||
on: # yamllint disable-line rule:truthy | ||
release: | ||
types: [published] | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
name: Receptorctl nox sessions | ||
|
||
on: | ||
on: # yamllint disable-line rule:truthy | ||
workflow_call: | ||
inputs: | ||
python-version: | ||
|
@@ -17,7 +17,10 @@ on: | |
description: Whether to perform go binary download. | ||
required: false | ||
default: false | ||
|
||
go-version: | ||
type: string | ||
description: The Go version to use. | ||
required: false | ||
env: | ||
FORCE_COLOR: 1 | ||
NOXSESSION: ${{ inputs.session }} | ||
|
@@ -30,32 +33,32 @@ jobs: | |
Run `receptorctl` ${{ inputs.session }} session | ||
|
||
steps: | ||
- name: Download the `receptor` binary | ||
if: fromJSON(inputs.download-receptor) | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: receptor | ||
path: /usr/local/bin/ | ||
|
||
- name: Set executable bit on the `receptor` binary | ||
if: fromJSON(inputs.download-receptor) | ||
run: sudo chmod a+x /usr/local/bin/receptor | ||
|
||
- name: Set up nox | ||
uses: wntrblm/[email protected] | ||
with: | ||
python-versions: ${{ inputs.python-version }} | ||
|
||
- name: Check out the source code from Git | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 # Needed for the automation in Nox to find the last tag | ||
sparse-checkout: receptorctl | ||
|
||
- name: Provision nox environment for ${{ env.NOXSESSION }} | ||
run: nox --install-only | ||
working-directory: ./receptorctl | ||
|
||
- name: Run `receptorctl` nox ${{ env.NOXSESSION }} session | ||
run: nox --no-install | ||
working-directory: ./receptorctl | ||
- name: Download the `receptor` binary | ||
if: fromJSON(inputs.download-receptor) | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: receptor-${{ inputs.go-version }} | ||
path: /usr/local/bin/ | ||
|
||
- name: Set executable bit on the `receptor` binary | ||
if: fromJSON(inputs.download-receptor) | ||
run: sudo chmod a+x /usr/local/bin/receptor | ||
|
||
- name: Set up nox | ||
uses: wntrblm/[email protected] | ||
with: | ||
python-versions: ${{ inputs.python-version }} | ||
|
||
- name: Check out the source code from Git | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 # Needed for the automation in Nox to find the last tag | ||
sparse-checkout: receptorctl | ||
|
||
- name: Provision nox environment for ${{ env.NOXSESSION }} | ||
run: nox --install-only | ||
working-directory: ./receptorctl | ||
|
||
- name: Run `receptorctl` nox ${{ env.NOXSESSION }} session | ||
run: nox --no-install | ||
working-directory: ./receptorctl |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
--- | ||
name: Triage | ||
|
||
on: | ||
on: # yamllint disable-line rule:truthy | ||
issues: | ||
types: | ||
- opened | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's not
required: true
, I'd at least set adefault: unversioned
or smth.