Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go action failures when artifact already exists #1053

Merged
merged 7 commits into from
May 30, 2024

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.60%. Comparing base (8d1f142) to head (2eda9e3).
Report is 65 commits behind head on devel.

@@            Coverage Diff             @@
##            devel    #1053      +/-   ##
==========================================
+ Coverage   42.01%   42.60%   +0.58%     
==========================================
  Files          42       45       +3     
  Lines        6640     7220     +580     
==========================================
+ Hits         2790     3076     +286     
- Misses       3629     3920     +291     
- Partials      221      224       +3     

see 5 files with indirect coverage changes

Components Coverage Δ
Go 42.01% <ø> (ø)
Receptorctl 49.31% <ø> (∅)

@thom-at-redhat thom-at-redhat marked this pull request as ready for review May 30, 2024 13:16
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thom-at-redhat thom-at-redhat merged commit b082c51 into ansible:devel May 30, 2024
21 checks passed
@thom-at-redhat thom-at-redhat deleted the fix_upload_artifact branch May 30, 2024 17:32
go-version:
type: string
description: The Go version to use.
required: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's not required: true, I'd at least set a default: unversioned or smth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants