Addressing the temporary excludes - cleanup work #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruchip16
requested review from
ssbarnea,
ganeshrn and
trishnaguha
and removed request for
a team
|
@Ruchip16 Please rebase and eliminate unrelated changes from commit. |
for more information, see https://pre-commit.ci
This was referenced Apr 5, 2023
Merged
Merged
This was referenced Apr 13, 2023
|
Closing this PR because above referenced PRs related to this PR have already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cidrblock @ssbarnea as i am removing one by one line and then run the
tox -e lintcommand and there were no errors till now, so just wanted to confirm that I am doing the right thing?Related to #73