Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ v3 major work in progress #73

Closed
ssbarnea opened this issue Mar 27, 2023 · 3 comments
Closed

⚠️ v3 major work in progress #73

ssbarnea opened this issue Mar 27, 2023 · 3 comments
Assignees

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Mar 27, 2023

Please see below:

@ssbarnea ssbarnea pinned this issue Mar 27, 2023
@cidrblock
Copy link
Contributor

Multiple pytest plugins related to ansible exist, the goal here is to combine them into one here. Please see the following community discussion topic ansible-community/community-topics#203

As a safeguard, a new branch was created called stable/2.x on March 27th 2023. If you rely on functionality from the master branch which was not in the 2.2.4 release, please use that branch if you encounter errors.

The general approach now is:

  • Rename the master branch to main
  • Modernize the packaging based on changes to python packaging over the past couple of years
  • Add several checks via pre-commit, including black, pylint, flake8m mypy and others
  • Merge the functionality from pytest-ansible-units into the repo

More to come here, but just wanted to give everyone a heads up on the approach

@ssbarnea
Copy link
Member Author

@Ruchip16 You can now start addresing the temporary excludes from https://github.com/ansible-community/pytest-ansible/blob/main/pyproject.toml#L87-L125 -- basically remove one by one while fixing them. You remove the line, run the linter again and change the code to address the issue.

Most of them should be very easy to fix but if you spot some that you cannot figure exactly how to do, skip them and do the others. You can later talk with me and/or @cidrblock and see how to deal with the remaining ones. In fact @shatakshiiii could also give you some hints as she also did the same kind of cleanup work in the past.

@Ruchip16
Copy link
Member

@Ruchip16 You can now start addresing the temporary excludes from https://github.com/ansible-community/pytest-ansible/blob/main/pyproject.toml#L87-L125 -- basically remove one by one while fixing them. You remove the line, run the linter again and change the code to address the issue.

Most of them should be very easy to fix but if you spot some that you cannot figure exactly how to do, skip them and do the others. You can later talk with me and/or @cidrblock and see how to deal with the remaining ones. In fact @shatakshiiii could also give you some hints as she also did the same kind of cleanup work in the past.

cool, am on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants