Capture sanity check warnings and display them #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Aug 27, 2021
webknjaz
reviewed
Aug 27, 2021
webknjaz
reviewed
Aug 27, 2021
webknjaz
reviewed
Aug 27, 2021
webknjaz
reviewed
Aug 27, 2021
webknjaz
reviewed
Aug 31, 2021
webknjaz
reviewed
Aug 31, 2021
webknjaz
reviewed
Aug 31, 2021
| result = util.run_command(self._ansible_command, debug=self._config.debug) | ||
| with warnings.catch_warnings(record=True) as warns: | ||
| warnings.filterwarnings("default", category=MoleculeRuntimeWarning) | ||
| self._config.driver.sanity_checks() |
There was a problem hiding this comment.
I think we should only catch warnings coming from this invocation.
There was a problem hiding this comment.
That is what is happening with record, when the context is destroyed the filter is also reset. At least that is what docs are saying.
There was a problem hiding this comment.
I meant that we shouldn't suppress those warnings in run_command()
Captures runtime warnings raise by driver.sanity_check() and display them at the end in case of failure. Related: ansible-community/molecule-podman#76
tadeboro
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captures runtime warnings raise by driver.sanity_check() and
display them at the end in case of failure.
Related: ansible-community/molecule-podman#76