This repository has been archived by the owner on Jan 8, 2023. It is now read-only.
Raise runtime warning on unsupported configurations #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Aug 27, 2021
Captures runtime warnings raise by driver.sanity_check() and display them at the end in case of failure. Related: ansible-community/molecule-podman#76
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Aug 27, 2021
Captures runtime warnings raise by driver.sanity_check() and display them at the end in case of failure. Related: ansible-community/molecule-podman#76
webknjaz
reviewed
Aug 30, 2021
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Aug 31, 2021
Captures runtime warnings raise by driver.sanity_check() and display them at the end in case of failure. Related: ansible-community/molecule-podman#76
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Aug 31, 2021
Captures runtime warnings raise by driver.sanity_check() and display them at the end in case of failure. Related: ansible-community/molecule-podman#76
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Aug 31, 2021
Captures runtime warnings raise by driver.sanity_check() and display them at the end in case of failure. Related: ansible-community/molecule-podman#76
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Aug 31, 2021
Captures runtime warnings raise by driver.sanity_check() and display them at the end in case of failure. Related: ansible-community/molecule-podman#76
ssbarnea
force-pushed
the
fix/more
branch
2 times, most recently
from
31329eb to
0aad678
Compare
Instead of removing support for Ansible 2.9, do raise a runtime warning when the unsupported configuration is detected. Molecule will catch and display these warnings when tests are failing, telling users to try newer versions. Related: #70
tadeboro
approved these changes
Sep 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of removing support for Ansible 2.9, do raise a runtime
warning when the unsupported configuration is detected. Molecule
will catch and display these warnings when tests are failing, telling
users to try newer versions.
Related: #70 #60