-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for notification template copy and advanced search #8780
Add support for notification template copy and advanced search #8780
Conversation
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this code locally, changes seem to be working as expected.
@mabashian found this items:
|
668569e
to
ad20d6c
Compare
Build succeeded.
|
Good catch, this actually applies to all the copy buttons in the app but they all share the same component so the fix here should apply to all.
This looks like an API bug to me. I filed this issue: #8919. The field that you're searching on isn't actually the field you wan though. You want to be searching on
I fixed this |
OK @tiagodread i think this is ready for another look |
Build succeeded.
|
…e and notification_type attributes.
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the user can now copy notifications and it keep working on different places like
templates
credentials
projects
inventories
notifications
Tests covered by 5804
Build succeeded (gate pipeline).
|
SUMMARY
link #7879
Copy:
Search:
ISSUE TYPE
COMPONENT NAME