Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for notification template copy and advanced search #8780

Merged

Conversation

mabashian
Copy link
Member

SUMMARY

link #7879

Copy:

copy

Search:

advanced_search

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • UI

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this code locally, changes seem to be working as expected.

@tiagodread
Copy link
Contributor

@mabashian found this items:

  • If the copy button was clicked twice before the first request finish the user see:

image

  • Advanced search for type doesn’t work:

image

  • (Not related to this PR) The user can hit the test button many times while the notification test is still running

@tiagodread tiagodread self-assigned this Dec 14, 2020
@mabashian mabashian force-pushed the 7879-notif-copy-search branch from 668569e to ad20d6c Compare December 15, 2020 22:09
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@mabashian
Copy link
Member Author

@tiagodread

If the copy button was clicked twice before the first request finish the user see:

Good catch, this actually applies to all the copy buttons in the app but they all share the same component so the fix here should apply to all.

Advanced search for type doesn’t work

This looks like an API bug to me. I filed this issue: #8919. The field that you're searching on isn't actually the field you wan though. You want to be searching on notification_type. type is a field with only one possible value right now: notification_template. Im not quite sure what the function of this field is.

notif_search

(Not related to this PR) The user can hit the test button many times while the notification test is still running

I fixed this

@mabashian
Copy link
Member Author

OK @tiagodread i think this is ready for another look

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@unlikelyzero unlikelyzero added the type:feature prioritized on a feature board label Dec 16, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@tiagodread tiagodread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the user can now copy notifications and it keep working on different places like

templates
credentials
projects
inventories
notifications

Tests covered by 5804

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a5e54c3 into ansible:devel Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature prioritized on a feature board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants