Fixes issues with extra var prompting in workflow nodes #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
Non-workflow scenarios locally tested:
I did come across #4293 (comment) The way I reproduced was by creating a JT with default and promptable extra vars that look like:
When creating the workflow node I changed the variables to look like:
Editing the node results in the extra vars looking like:
I'll work on including a fix for ^^ in this PR |
mabashian
changed the title
|
Workflow scenarios tested:
|
…orm. Small bug fixes for extra var corner cases in workflow nodes.
mabashian
changed the title
|
Build succeeded.
|
jlmitch5
approved these changes
Aug 22, 2019
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
link #4293
The easiest way to reproduce the
pipein the extra vars was to:Here's a gif of part of that process:
This bug got introduced by #3669 which was a fix for a bug introduced by #3359.
The short of it is that
params.currentValues.extra_datacan be an object (json) or a string (yaml) when being processed and we need to be able to handle both scenarios.I went back and doubled checked that yaml comments were still being presented to the user on launch (see #3359 (comment) for more info on that).
I also dropped a commit in here to address the prompt tab spacing issues seen when launching a job from the job template form.
Before:
After:
ISSUE TYPE
COMPONENT NAME
AWX VERSION
awx: 6.1.0
ADDITIONAL INFORMATION
In addition to testing out the cases listed in #4293 and #3359 I've done some manual regression testing in the other places where extra variables are prompted. Schedules is one place that can be impacted by prompting changes. I double checked to make sure that promptable extra vars display properly when prompted for a schedule (both add and edit).