Ensures extra vars are converted to yaml before being passed along to prompt steps #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
This was referenced Aug 19, 2019
shanemcd
pushed a commit
to shanemcd/awx
that referenced
this pull request
Sep 13, 2019
Added nightwatch stylesheet for E2E configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
link #3567
Regression introduced by #3359
Tested the scenario outlined in 3567 as well as the yaml comment scenario fixed by 3359. These changes should satisfy both cases. Note that
params.launchConf.defaults.extra_varsis already in yaml form so we don't need to worry about dumping that.ISSUE TYPE
COMPONENT NAME