Molecule: Different fix for new Cython #1494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first attempt (ansible#1492) was unfortunately wrong in two ways. We need to pin the dependency in inside the container, not as a molecule dependency. Also it seems like the Cython pin needs to happen *earlier* but an easy solution is to just pin pyyaml to an old version instead for now until yaml/pyyaml#601 is resolved. Signed-off-by: Rick Elrod <[email protected]>
|
Backing this to draft for now, I want to see if #1463 fixes the issue instead. |
|
Closing, I prefer #1463 to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The first attempt (#1492) was unfortunately wrong in two ways. We need to pin the dependency in inside the container, not as a molecule dependency. Also it seems like the Cython pin needs to happen earlier but an easy solution is to just pin pyyaml to an old version instead for now until yaml/pyyaml#601 is resolved.
Here's an AWX CI run showing this fix works, this time: ansible/awx#14251
I will revert #1493 as well, it is useless.
ISSUE TYPE