Pin Cython for tests, currently PyYAML cannot build #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rick Elrod <[email protected]>
gamuniz
approved these changes
Jul 17, 2023
relrod
added a commit
to relrod/awx-operator
that referenced
this pull request
Jul 17, 2023
See: yaml/pyyaml#601 Signed-off-by: Rick Elrod <[email protected]>
relrod
added a commit
to relrod/awx-operator
that referenced
this pull request
Jul 17, 2023
This reverts commit 45f7545.
relrod
added a commit
to relrod/awx-operator
that referenced
this pull request
Jul 17, 2023
The first attempt (ansible#1492) was unfortunately wrong in two ways. We need to pin the dependency in inside the container, not as a molecule dependency. Also it seems like the Cython pin needs to happen *earlier* but an easy solution is to just pin pyyaml to an old version instead for now until yaml/pyyaml#601 is resolved. Signed-off-by: Rick Elrod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Try to work around yaml/pyyaml#601 for now with a pin.
ISSUE TYPE
ADDITIONAL INFORMATION
https://pypi.org/project/Cython/ - 3.0.0 just landed an hour ago and caused this breakage.