-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow {web_,task_,}replicas to be 0 and split out molecule tests #1468
Allow {web_,task_,}replicas to be 0 and split out molecule tests #1468
Conversation
Signed-off-by: Rick Elrod <[email protected]>
Signed-off-by: Rick Elrod <[email protected]>
…ous fields Signed-off-by: Rick Elrod <[email protected]>
Signed-off-by: Rick Elrod <[email protected]>
Signed-off-by: Rick Elrod <[email protected]>
7d033ca
to
e46a1de
Compare
@@ -285,5 +285,7 @@ | |||
|
|||
- name: Verify the resource pod name is populated. | |||
assert: | |||
that: awx_task_pod_name != '' | |||
that: | |||
- awx_task_pod_name != '' | |||
fail_msg: "Could not find the tower pod's name." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to think about moving away from the tower naming scheme in errors since we changed the pod_names? I will leave this as a single comment since it isn't directly applied to the PR, more just for others to see and think about potentially changing it if there are others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but it doesn't have to prevent this from merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
big plus 1 for the test changes around tags to help with the slowness and fixes for replicas
I like the way you split out the replicas check to |
SUMMARY
(Replaces #1464 because I think there is a 👻 CI check there that is in a weird state.)
There is quite a bit going on here.
On the user-facing side:
replicas
,web_replicas
, andtask_replicas
to be0
. Previously this was interpreted as a falsy value and messed up the templating logic. Now we compare it to the default (empty string) instead. Fixes AWX doesn't scale in to 0 replicas #1454.On the testing side:
AWX
instance we are testing with. You just import that withinclude_tasks
.additional_fields
var so that you can actually customize theAWX
definition to test how changes to fields interact.ci.yaml
) so that if we add chunks of other tests later, they can each run in their own separate instance, in parallel.ci.yaml
so that people can run the tests in the own forks on their own feature branches.ISSUE TYPE