Allow {web_,task_,}replicas to be 0 #1464
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There is quite a bit going on here.
On the user-facing side:
replicas
,web_replicas
, andtask_replicas
to be0
. Previously this was interpreted as a falsy value and messed up the templating logic. Now we compare it to the default (empty string) instead. Fixes AWX doesn't scale in to 0 replicas #1454.On the testing side:
AWX
instance we are testing with. You just import that withinclude_tasks
.additional_fields
var so that you can actually customize theAWX
definition to test how changes to fields interact.ci.yaml
) so that if we add chunks of other tests later, they can each run in their own separate instance, in parallel.ci.yaml
so that people can run the tests in the own forks on their own feature branches.ISSUE TYPE