This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
Sync with upstream #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ansible-lint is executed from the root directory of the workspace the algorithm that it uses to find configuration for a particular file is not involved. To compensate, the extension now mimics that behavior, searching the directory structure, going up from the investigated file. At the same time, it is still possible to force a particular config file through arguments provided in the extension settings. The configuration file that is actually used is now correctly identified for the purpose of marking configured finding groups as warnings.
ganeshrn
approved these changes
Aug 25, 2021
|
Thank you! |
priyamsahoo
referenced
this pull request
in priyamsahoo/ansible-language-server
Sep 15, 2021
* Fix special characters in workspace and file paths (#15) * Advise yamllint installation and use (#16) * Fix handling of files with CRLF line endings (#20) * Mimic linter's config file search algorithm (#22) Since ansible-lint is executed from the root directory of the workspace the algorithm that it uses to find configuration for a particular file is not involved. To compensate, the extension now mimics that behavior, searching the directory structure, going up from the investigated file. At the same time, it is still possible to force a particular config file through arguments provided in the extension settings. The configuration file that is actually used is now correctly identified for the purpose of marking configured finding groups as warnings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request synchronizes the language server implementation with the changes made to https://github.com/tomaciazek/vscode-ansible since fork.