Sync with upstream (#7)

* Fix special characters in workspace and file paths (#15)

* Advise yamllint installation and use (#16)

* Fix handling of files with CRLF line endings (#20)

* Mimic linter's config file search algorithm (#22)

Since ansible-lint is executed from the root directory of the workspace
the algorithm that it uses to find configuration for a particular file
is not involved. To compensate, the extension now mimics that behavior,
searching the directory structure, going up from the investigated file.

At the same time, it is still possible to force a particular config file
through arguments provided in the extension settings.

The configuration file that is actually used is now correctly identified
for the purpose of marking configured finding groups as warnings.

src/providers/validationProvider.ts

@@ -12,6 +12,7 @@ import { ValidationManager } from '../services/validationManager';
 import { WorkspaceFolderContext } from '../services/workspaceManager';
 import { parseAllDocuments } from '../utils/yaml';
 import { libraryChecker } from '../utils/libraryChecker';
+import { parseAllDocuments } from '../utils/yaml';
 
 /**
  * Validates the given document.

src/services/ansibleConfig.ts

@@ -2,7 +2,7 @@ import * as child_process from 'child_process';
 import * as ini from 'ini';
 import * as _ from 'lodash';
 import * as path from 'path';
-import { URI } from 'vscode-uri';
+import { URL } from 'url';
 import { Connection } from 'vscode-languageserver';
 import { withInterpreter } from '../utils/misc';
 import { WorkspaceFolderContext } from './workspaceManager';
@@ -35,7 +35,7 @@ export class AnsibleConfig {
 
       const ansibleConfigResult = child_process.execSync(ansibleConfigCommand, {
         encoding: 'utf-8',
-        cwd: URI.parse(this.context.workspaceFolder.uri).path,
+        cwd: decodeURI(new URL(this.context.workspaceFolder.uri).pathname),
         env: ansibleConfigEnv,
       });
 

src/services/ansibleLint.ts

@@ -2,7 +2,7 @@ import * as child_process from 'child_process';
 import { ExecException } from 'child_process';
 import { promises as fs } from 'fs';
 import * as path from 'path';
-import { URI } from 'vscode-uri';
+import { URL } from 'url';
 import { promisify } from 'util';
 import {
   Connection,
@@ -53,7 +53,9 @@ export class AnsibleLint {
   ): Promise<Map<string, Diagnostic[]>> {
     let diagnostics: Map<string, Diagnostic[]> = new Map();
 
-    const workingDirectory = URI.parse(this.context.workspaceFolder.uri).path;
+    const workingDirectory = decodeURI(
+      new URL(this.context.workspaceFolder.uri).pathname
+    );
 
     const settings = await this.context.documentSettings.get(textDocument.uri);
 
@@ -71,13 +73,15 @@ export class AnsibleLint {
           textDocument.uri
         );
         if (ansibleLintConfigFile) {
-          ansibleLintConfigPath = URI.parse(ansibleLintConfigFile).path;
+          ansibleLintConfigPath = decodeURI(
+            new URL(ansibleLintConfigFile).pathname
+          );
           linterArguments = `${linterArguments} -c "${ansibleLintConfigPath}"`;
         }
       }
       linterArguments = `${linterArguments} --offline --nocolor -f codeclimate`;
 
-      const docPath = URI.parse(textDocument.uri).path;
+      const docPath = decodeURI(new URL(textDocument.uri).pathname);
       let progressTracker;
       if (this.useProgressTracker) {
         progressTracker = await this.connection.window.createWorkDoneProgress();
@@ -98,7 +102,7 @@ export class AnsibleLint {
 
         const [command, env] = withInterpreter(
           settings.ansibleLint.path,
-          `${linterArguments} "${docPath}"`,
+          `${linterArguments} --offline --nocolor -f codeclimate "${docPath}"`,
           settings.python.interpreterPath,
           settings.python.activationScript
         );
@@ -217,7 +221,7 @@ export class AnsibleLint {
               }
             }
             const path = `${workingDirectory}/${item.location.path}`;
-            const locationUri = URI.file(path).toString();
+            const locationUri = `file://${encodeURI(path)}`;
 
             let fileDiagnostics = diagnostics.get(locationUri);
             if (!fileDiagnostics) {