-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to configure docsite builds, allow to override collection URLs and installation instructions #26
Conversation
bd496a6
to
e7f8239
Compare
The PR now contains code that allows to override the way a collection URL is composed, and the way the collection installation command is composed. This resolves #15. For example, you can write the following in the configuration file for a docsite (the
(In case you're wondering, the configuration file format is perky's format: https://github.com/larryhastings/perky/#readme) |
FYI: before this can be un-WIP-ed, ansible-community/antsibull-core#7 needs to be merged, antsibull-core 1.2.0 released, and f5a727d removed from this branch. But that's basically the only thing that's missing from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! really looking forward to it
@@ -0,0 +1,8 @@ | |||
minor_changes: | |||
- "The ``sphinx-init`` subcommand now also creates an ``antsibull-docs.cfg`` file and moves configuration settings from CLI flags in ``build.sh`` to this configuration file (https://github.com/ansible-community/antsibull-docs/pull/26)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, this should make for some interesting possibilities in https://github.com/ansible-community/github-docs-build/ maybe 🤔
419ab55
to
21da701
Compare
Now that antsibull-core 1.2.0 has been released, this can be merged. |
@briantist thanks for reviewing this! |
Depends on ansible-community/antsibull-core#7.
Fixes #15.