Improve config file mechanism #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no longer needed.
… only the explicit config files with provided one.
felixfontein
changed the title
|
I think this is ready for reviews. |
briantist
approved these changes
Aug 20, 2022
There was a problem hiding this comment.
Looks good to me, at least so far. Could possibly use some documentation so that dependent projects have something to follow? It's not (yet) completely clear to me what changes this requires or enables in downstream projects, but that could also be my relative lack of familiarity with the internals of the antsibull suite.
|
@briantist thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that dependent projects can have their own config without it having to be defined globally for all projects using antsibull-core.