-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible 7.0.0: Dependencies, changelog and porting guide #179
Ansible 7.0.0: Dependencies, changelog and porting guide #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented on IRC, there's no entry in 7/changelog.yaml, which causes the changelog to be incorrect (wrong release date). (The changelog is also included in the tarball BTW.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rooftopcellist I auto-generated the 7/CHANGELOG-v7.rst and 7/changelog.yaml with the below command and updated those changes on your pr branch here. Also, as Felix mentioned the tarball contains the outdated changelog.
antsibull-build changelog --data-dir=./7 7.0.0
Update CHANGELOG-v7.rst changelog.yaml
@Ompragash thank you for the patch. I just merged it into my PR. I was able to generate the changelog.yaml diff by re-running the build-single-release.yaml without I re-built the .whl and .tar.gz so that it has the correct changelog.yaml in it. I did it with antsibull-build directly.
|
FYI, the command @Ompragash shared to generate/update the changelog files didn't work for me for some reason. So these are the steps I ended up taking:
There's probably a better way to have done this. But this works for now. |
@Ompragash said:
As @felixfontein mentioned to me on IRC, separately running
7.0.0:
changes:
release_summary: 'Release Date: 2022-11-22
`Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_'
release_date: '2022-11-22'
Hopefully, we can add native support for this to antsibull so you don't have to result to these type of workarounds next cycle. |
Awesome, thank you for sharing that @gotmax23 ! |
@gotmax23 FYI: It isn't necessary but it comes to the rescue to generate |
Yeah, it is useful in some cases. I just used it, because I wanted to verify my changelog entries in #183 were formatted correctly but not build the entire ansible distribution :). |
No description provided.