Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out PFC priority group map test case configuration #395

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Comment out PFC priority group map test case configuration #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bdaada
Comment out PFC priority group test case configuration
stalabi1 Jun 11, 2024
516445b
Add fragment
stalabi1 Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/395-comment-out-pfc-pg-test-cases.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- sonic_qos_maps - Comment out PFC priority group map tests cases (https://github.com/ansible-collections/dellemc.enterprise_sonic/pull/395).
4 changes: 2 additions & 2 deletions plugins/module_utils/network/sonic/facts/qos_maps/qos_maps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ def populate_facts(self, connection, ansible_facts, data=None):
objs = data
facts = {}
if objs:
params = utils.validate_config(self.argument_spec, {'config': remove_empties(objs)})
facts['qos_maps'] = params['config']
params = utils.validate_config(self.argument_spec, {'config': objs})
facts['qos_maps'] = remove_empties(params['config'])
ansible_facts['ansible_network_resources'].update(facts)
return ansible_facts

Expand Down
58 changes: 29 additions & 29 deletions tests/regression/roles/sonic_qos_maps/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
ansible_connection: httpapi
module_name: qos_maps

# PFC priority group map configuration only supported on Z9664, Z9432 and Z9864 platforms
tests:
- name: test_case_01
description: Configure QoS maps
Expand Down Expand Up @@ -42,11 +42,11 @@ tests:
entries:
- dot1p: 0
queue_index: 0
pfc_priority_pg_maps:
- name: pfc_pg_map1
entries:
- dot1p: 0
pg_index: 0
# pfc_priority_pg_maps:
# - name: pfc_pg_map1
# entries:
# - dot1p: 0
# pg_index: 0

- name: test_case_02
description: Add entries and maps to existing QoS maps configuration
Expand Down Expand Up @@ -111,11 +111,11 @@ tests:
entries:
- dot1p: 4
queue_index: 5
pfc_priority_pg_maps:
- name: pfc_pg_map1
entries:
- dot1p: 3
pg_index: 5
# pfc_priority_pg_maps:
# - name: pfc_pg_map1
# entries:
# - dot1p: 3
# pg_index: 5
- name: test_case_03
description: Modify existing QoS maps configuration
state: merged
Expand Down Expand Up @@ -155,11 +155,11 @@ tests:
entries:
- dot1p: 0
queue_index: 7
pfc_priority_pg_maps:
- name: pfc_pg_map1
entries:
- dot1p: 0
pg_index: 1
# pfc_priority_pg_maps:
# - name: pfc_pg_map1
# entries:
# - dot1p: 0
# pg_index: 1

- name: test_case_04
description: Replace QoS maps configuration
Expand Down Expand Up @@ -255,13 +255,13 @@ tests:
queue_index: 0
- dot1p: 1
queue_index: 1
pfc_priority_pg_maps:
- name: pfc_pg_map1
entries:
- dot1p: 0
pg_index: 0
- dot1p: 1
pg_index: 1
# pfc_priority_pg_maps:
# - name: pfc_pg_map1
# entries:
# - dot1p: 0
# pg_index: 0
# - dot1p: 1
# pg_index: 1

- name: test_case_06
description: Testing QoS maps deletion by map name, entries key, and entries non-key attribute
Expand Down Expand Up @@ -315,12 +315,12 @@ tests:
- dot1p: 0
- dot1p: 1
queue_index: 1
pfc_priority_pg_maps:
- name: pfc_pg_map1
entries:
- dot1p: 0
- dot1p: 1
pg_index: 1
# pfc_priority_pg_maps:
# - name: pfc_pg_map1
# entries:
# - dot1p: 0
# - dot1p: 1
# pg_index: 1

- name: test_case_07
description: Delete all QoS maps configuration
Expand Down
Loading