Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out PFC priority group map test case configuration #395

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Jun 11, 2024

SUMMARY

I commented out PFC priority group map test case configuration since the configuration is only supported on certain platforms.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

sonic_qos_maps

OUTPUT

regression-2024-06-11-10-14-49.html.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this adjustment to match the SONiC implementation.

Approved.

@kerry-meyer kerry-meyer merged commit aab36aa into ansible-collections:main Jun 13, 2024
16 checks passed
@stalabi1 stalabi1 deleted the qos_maps branch July 10, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants