Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_deploy_ovf: Fix sanity tests #1825

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

After merging #1803 the daily CI run fails the sanity tests:

plugins/modules/vmware_deploy_ovf.py:279:161: E501: line too long (164 > 160 characters)
plugins/modules/vmware_deploy_ovf.py:0:0: invalid-documentation: DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got ['Alexander Nikitin (@ihumster)', 'Matt Martz ']
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_deploy_ovf

ADDITIONAL INFORMATION

Sanity (Ⓐstable-2.14)

@mariolenz mariolenz changed the title [WIP] vmware_deploy_ovf: Fix author [WIP] vmware_deploy_ovf: Fix sanity tests Aug 13, 2023
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/20f199c7e19e4c6aab5f9af751b0b76c

✔️ ansible-tox-linters SUCCESS in 8m 40s
✔️ build-ansible-collection SUCCESS in 9m 30s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006283478 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 18m 02s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006283479 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 54m 18s
✔️ ansible-galaxy-importer SUCCESS in 4m 57s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/42b472774f194597a32f80a719fc9da3

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 9m 41s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006285119 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 18m 41s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006284844 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006284845 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 22s

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz
Copy link
Collaborator Author

@ihumster Could you please have a quick look at this? I don't think I've broken anything, but just to make sure ;-)

@ihumster
Copy link
Collaborator

@mariolenz Looks okay. I'll experiment with multi-strings in regular expressions and if anything come up with a code fix.

@mariolenz mariolenz changed the title [WIP] vmware_deploy_ovf: Fix sanity tests vmware_deploy_ovf: Fix sanity tests Aug 14, 2023
@mariolenz
Copy link
Collaborator Author

Thx @ihumster!

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/dde00a300e0d43b88bb69b9e9829bc73

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 7m 37s
✔️ ansible-galaxy-importer SUCCESS in 4m 55s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8d0b3e4 into ansible-collections:main Aug 14, 2023
@mariolenz mariolenz deleted the fix_1803_sanity branch August 14, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants