add url deploy feature #1803
add url deploy feature #1803
Conversation
|
Build failed. ❌ ansible-tox-linters FAILURE in 8m 33s |
|
Build failed. ❌ ansible-tox-linters FAILURE in 8m 31s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 59s |
|
@mariolenz Hello. Please, tell me what is NODE_FAILURE? |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 53s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 32s |
|
@alinabuzachis And now ansible-test-cloud-integration-vcenter7_2esxi-stable215 failed on vmware_vmotion: Create VM task. =( |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 51s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 32s |
|
recheck |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 33s |
|
@mariolenz my two PR (this and #1803) passed CI checks. Are there any stoppers to include them in the master branch? |
|
@mariolenz I gave the wrong link, sorry. I mean #1806 |
If you don't mind, I will continue to watch the Issues and offer corrections for them in the form of a PR |
|
Sorry, I wasn't able to review this PR or #1806 today. I hope I'll find the time to do it this week, but at the moment there are so many other things to do at work 😩
Sure, go on! This is very much appreciated 😃 |
|
@mariolenz I fix some sanity tests errors - move import six to ansible.module_utils.six, but now I can't replace urlopen function on open_url. They are too different. I added to sanity ignore files 'replace-urlopen!skip' for module, if it's allowed. |
|
Build failed. ❌ ansible-tox-linters FAILURE in 8m 48s |
|
Build failed. ❌ ansible-tox-linters FAILURE in 8m 37s |
|
Build failed. ❌ ansible-tox-linters FAILURE in 8m 26s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 45s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 33s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 22s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 40s |
|
recheck |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 38s |
|
@mariolenz And this CI is done. |
| exp1 = r"(?P<url>(?:(?P<scheme>[a-zA-Z]+:\/\/)?(?P<hostname>(?:[-a-zA-Z0-9@%_\+~#=]{1,256}\.){1,256}(?:[-a-zA-Z0-9@%_\+~#=]{1,256})))" | ||
| exp2 = r"(?::(?P<port>[[:digit:]]+))?(?P<path>(?:\/[-a-zA-Z0-9!$&'()*+,\\\/:;=@\[\]._~%]*)*)(?P<query>(?:(?:\#|\?)[-a-zA-Z0-9!$&'()*+,\\\/:;=@\[\]._~]*)*))" |
There was a problem hiding this comment.
I hope I'll never have to troubleshoot this 😆
There was a problem hiding this comment.
It's actually a pretty simple regular expression. =) It beats any URL to the full set of its constituent parts (scheme, hostname, path, etc)
There was a problem hiding this comment.
Well, I think I'm not that bad at regular expressions... but if you think this simple, I don't want to see one that you consider complex 😛 SCNR
There was a problem hiding this comment.
I'm afraid we just need to catch our luck with CI again =(
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 06s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 42s |
|
recheck |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 43s |
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 8m 33s |
|
@ihumster I don't know why the CI didn't complain earlier, but it looks like this line: is a few characters too long. What do you think would be the best way to make sure we're below 160 characters per line? Split it into exp2 and exp3 somehow or use a multi-line string or what? The CI also started to dislike the author documentation. I think I was able to fix this in #1825 but it would be best to fix both issues in one go. |
I think it is necessary to split by exp2, exp3, as well. I'm not sure if multi-line will be accepted re... |
|
Although stackoverflow says you can via taking into account the indents of course =) |
vmware_deploy_ovf: Fix sanity tests SUMMARY After merging #1803 the daily CI run fails the sanity tests: plugins/modules/vmware_deploy_ovf.py:279:161: E501: line too long (164 > 160 characters) plugins/modules/vmware_deploy_ovf.py:0:0: invalid-documentation: DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got ['Alexander Nikitin (@ihumster)', 'Matt Martz '] ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_deploy_ovf ADDITIONAL INFORMATION Sanity (Ⓐstable-2.14)
SUMMARY
Add to vmware_deploy_ovf 'url' parameter (mutually exclusive with 'ovf' parameter) for remote deploy from http server.
ISSUE TYPE
COMPONENT NAME
vmware_deploy_ovf