Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_cluster_drs_recommendations - add a modul to apply the drs recommendations #1736

Merged
merged 10 commits into from
May 27, 2023
Merged

vmware_cluster_drs_recommendations - add a modul to apply the drs recommendations #1736

merged 10 commits into from
May 27, 2023

Conversation

Nina2244
Copy link
Contributor

SUMMARY

Add the Module to apply the drs recommendations.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_cluster_drs_recommendations

ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5b433d001baa4085944a109adc5b6a0b

❌ ansible-tox-linters FAILURE in 8m 30s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED
⚠️ ansible-test-units-community-vmware-python38 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/353865a208f84d9e9eb17c7d59daaf19

❌ ansible-tox-linters FAILURE in 8m 26s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED
⚠️ ansible-test-units-community-vmware-python38 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/09e372b5a81943b9b419baaa7f88a201

❌ ansible-tox-linters FAILURE in 8m 25s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED
⚠️ ansible-test-units-community-vmware-python38 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/40bb520acaba40ad9102c995e328aebf

❌ ansible-tox-linters FAILURE in 8m 32s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED
⚠️ ansible-test-units-community-vmware-python38 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/dcdba70e277240ebaea9b9518d8a4b71

✔️ ansible-tox-linters SUCCESS in 8m 47s
✔️ build-ansible-collection SUCCESS in 9m 32s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 42s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 10s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 33s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 29s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 51s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 FAILURE in 13m 12s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 32s

@Nina2244
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/90f844e59db84a558f322410a5b78ad4

✔️ ansible-tox-linters SUCCESS in 9m 16s
✔️ build-ansible-collection SUCCESS in 10m 01s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 46s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 50s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 31s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 18s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 50s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 22m 25s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 FAILURE in 52m 14s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 1h 01m 18s
✔️ ansible-galaxy-importer SUCCESS in 3m 44s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/096a3a09c6e9432c97b72f049cbca15c

✔️ ansible-tox-linters SUCCESS in 9m 51s
✔️ build-ansible-collection SUCCESS in 9m 47s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 58s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 53s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 50s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 46s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 14s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable214 FAILURE in 17m 08s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 33s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/acadeea1a4d44e869bb7143da9b58f81

✔️ ansible-tox-linters SUCCESS in 8m 39s
✔️ build-ansible-collection SUCCESS in 9m 16s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 20m 35s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 24s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 FAILURE in 55m 53s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 54m 02s
✔️ ansible-galaxy-importer SUCCESS in 3m 59s

mariolenz
mariolenz requested changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

plugins/modules/vmware_cluster_drs_recommendations.py Outdated Show resolved Hide resolved
plugins/modules/vmware_cluster_drs_recommendations.py Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c6da02852e8c47d2bb955ae08c374e0b

✔️ ansible-tox-linters SUCCESS in 9m 06s
✔️ build-ansible-collection SUCCESS in 9m 46s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 FAILURE in 15m 48s
✔️ ansible-galaxy-importer SUCCESS in 3m 57s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6ae58fd3347c488fa35fa3667762a234

✔️ ansible-tox-linters SUCCESS in 9m 00s
✔️ build-ansible-collection SUCCESS in 9m 38s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 22m 47s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 FAILURE in 23m 46s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 NODE_FAILURE Node request 200-0006004116 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 3m 58s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/47ecef98dd1b47be9cad6d7ada1c29eb

✔️ ansible-tox-linters SUCCESS in 8m 41s
✔️ build-ansible-collection SUCCESS in 9m 26s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 21m 51s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 07s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 FAILURE in 44m 38s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 45s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9343901c32d4449d8b4d94987f85d038

✔️ ansible-tox-linters SUCCESS in 8m 36s
✔️ build-ansible-collection SUCCESS in 9m 34s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable214 NODE_FAILURE Node request 200-0006005722 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 55m 34s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 FAILURE in 13m 10s
✔️ ansible-galaxy-importer SUCCESS in 4m 05s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e6329a7492b94fac87a0f4034e7feaae

✔️ ansible-tox-linters SUCCESS in 8m 44s
✔️ build-ansible-collection SUCCESS in 9m 21s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 18m 47s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable214 FAILURE in 18m 53s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 20s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/13010e6e1ade49a39bc1e10ef2346508

✔️ ansible-tox-linters SUCCESS in 8m 39s
✔️ build-ansible-collection SUCCESS in 9m 24s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable214 FAILURE in 14m 31s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 43s

@mariolenz
Copy link
Collaborator

recheck

@mariolenz mariolenz closed this May 27, 2023
@mariolenz mariolenz reopened this May 27, 2023
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7b8ea5a1a48e4ccfa445faf84fc16eff

✔️ ansible-tox-linters SUCCESS in 8m 59s
✔️ build-ansible-collection SUCCESS in 9m 42s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 FAILURE in 16m 02s
✔️ ansible-galaxy-importer SUCCESS in 3m 39s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/08bc5304176442a8941484e1f0a9e0f4

✔️ ansible-tox-linters SUCCESS in 8m 42s
✔️ build-ansible-collection SUCCESS in 9m 26s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 18m 32s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 09s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 55m 34s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 53m 26s
✔️ ansible-galaxy-importer SUCCESS in 3m 45s

mariolenz
mariolenz approved these changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/9df2b836219f4614a7a6324de9b4c7ef

✔️ ansible-tox-linters SUCCESS in 8m 40s
✔️ build-ansible-collection SUCCESS in 7m 29s
✔️ ansible-galaxy-importer SUCCESS in 4m 19s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f476a07 into ansible-collections:main May 27, 2023
@mariolenz mariolenz mentioned this pull request Jun 4, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 5, 2023
@mariolenz
meta/runtime.yml: Add missing modules (#1764)
b01f35d 
meta/runtime.yml: Add missing modules

SUMMARY
Add missing modules to meta/runtime.yml.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
runtime.yml
ADDITIONAL INFORMATION
#1675
#1702
#1704
#1736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
mergeit new_module New module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nina2244 @mariolenz