-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vsan_health_silent_checks module #1704
add vsan_health_silent_checks module #1704
Conversation
This module adds functionality to silence or reactivate health checks that should not cause alarms in the vCenter UI. A common usecase could be to silence health checks that require internet connectivity in airgapped installations
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 57s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, one problem I see is that the module isn't idempotent. I've disabled the timedrift
check and this worked fine, but when I ran the task again I got another change. The module should return OK
in this case because there's no change needed.
I'm AFK for a couple of days, so don't expect another reaction from me until next week.
Co-authored-by: Mario Lenz <[email protected]>
@mariolenz thanks for the feedback! I'll implement a check for to make the module idempotent next week. Have a great holiday ;) |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 33s |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 49s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 8m 32s |
SUMMARY
This module adds functionality to silence or reactivate health checks that should not cause alarms in the vCenter UI. A common usecase could be to silence health checks that require internet connectivity in airgapped installations
ISSUE TYPE
COMPONENT NAME
vsan_health_silent_checks
ADDITIONAL INFORMATION