Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vsan_health_silent_checks module #1704

Conversation

p-fruck
Copy link
Contributor

@p-fruck p-fruck commented Apr 5, 2023

SUMMARY

This module adds functionality to silence or reactivate health checks that should not cause alarms in the vCenter UI. A common usecase could be to silence health checks that require internet connectivity in airgapped installations

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vsan_health_silent_checks

ADDITIONAL INFORMATION

This module adds functionality to silence or reactivate health
checks that should not cause alarms in the vCenter UI. A common
usecase could be to silence health checks that require internet
connectivity in airgapped installations
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, one problem I see is that the module isn't idempotent. I've disabled the timedrift check and this worked fine, but when I ran the task again I got another change. The module should return OK in this case because there's no change needed.

I'm AFK for a couple of days, so don't expect another reaction from me until next week.

plugins/modules/vsan_health_silent_checks.py Show resolved Hide resolved
plugins/modules/vsan_health_silent_checks.py Outdated Show resolved Hide resolved
@p-fruck
Copy link
Contributor Author

p-fruck commented Apr 6, 2023

@mariolenz thanks for the feedback! I'll implement a check for to make the module idempotent next week. Have a great holiday ;)

@p-fruck p-fruck requested a review from mariolenz April 13, 2023 21:54
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d50069941b1c468c807162033fa4be45

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 7m 23s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 22s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 07s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 46s
✔️ ansible-galaxy-importer SUCCESS in 3m 48s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 86447cd into ansible-collections:main Apr 17, 2023
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 5, 2023
meta/runtime.yml: Add missing modules

SUMMARY
Add missing modules to meta/runtime.yml.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
runtime.yml
ADDITIONAL INFORMATION
#1675
#1702
#1704
#1736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants