Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vmware_object_role_permission): Clarify vCenter compatibility #1705

Conversation

p-fruck
Copy link
Contributor

@p-fruck p-fruck commented Apr 5, 2023

SUMMARY

This update to the documentation should clarify that the module is compatible with ESXi and vCenter which previously wasn't clear by reading through the module description.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vmware_object_role_permission and vmware_object_role_permission_info

ADDITIONAL INFORMATION

This PR is similar to #1678

This update to the documentation should clarify that the module is
compatible with ESXi and vCenter which previously wasn't clear by
reading through the module description.
@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

@p-fruck
Copy link
Contributor Author

p-fruck commented Apr 25, 2023

recheck

@softwarefactory-project-zuul
Copy link

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

@mariolenz
Copy link
Collaborator

recheck

@mariolenz
Copy link
Collaborator

@p-fruck I think the CI fails because of the vSphere eval license used there expired. I'll try to ping people to fix this so we can get this PR merged.

@mariolenz
Copy link
Collaborator

@p-fruck FYI: #1723

@mariolenz
Copy link
Collaborator

recheck

@mariolenz mariolenz closed this May 7, 2023
@mariolenz mariolenz reopened this May 7, 2023
@mariolenz
Copy link
Collaborator

recheck

@p-fruck
Copy link
Contributor Author

p-fruck commented May 8, 2023

recheck

@p-fruck
Copy link
Contributor Author

p-fruck commented May 8, 2023

recheck

@p-fruck
Copy link
Contributor Author

p-fruck commented May 8, 2023

@mariolenz

Failed to add host to vCenter 'vcenter.test' : ('License not available to perform the operation.'

Still some remaining licensing issues?

@mariolenz
Copy link
Collaborator

@mariolenz

Failed to add host to vCenter 'vcenter.test' : ('License not available to perform the operation.'

Still some remaining licensing issues?

Yep, CI still is broken :-(

@jillr
Copy link
Contributor

jillr commented May 8, 2023

recheck

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

@mariolenz mariolenz closed this May 9, 2023
@mariolenz mariolenz reopened this May 9, 2023
@mariolenz
Copy link
Collaborator

recheck

@mariolenz mariolenz closed this May 10, 2023
@mariolenz mariolenz reopened this May 10, 2023
@jillr
Copy link
Contributor

jillr commented May 10, 2023

recheck

1 similar comment
@jillr
Copy link
Contributor

jillr commented May 10, 2023

recheck

@mariolenz
Copy link
Collaborator

recheck

@mariolenz
Copy link
Collaborator

recheck

@mariolenz mariolenz closed this May 11, 2023
@mariolenz mariolenz reopened this May 11, 2023
@mariolenz
Copy link
Collaborator

recheck

@mariolenz
Copy link
Collaborator

recheck

@mariolenz mariolenz added the documentation Improvements or additions to documentation label May 16, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0c691acb423944ff910e9b8868a7ed2f

✔️ ansible-tox-linters SUCCESS in 8m 35s
✔️ build-ansible-collection SUCCESS in 9m 20s
ansible-test-sanity-docker-devel FAILURE in 9m 04s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 29s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 16s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 12m 15s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 38s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 23m 19s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 07s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 52m 14s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 54m 41s
✔️ ansible-galaxy-importer SUCCESS in 3m 32s

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @p-fruck!

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/238296eb583e40ae83994d6eb8af54b0

✔️ ansible-tox-linters SUCCESS in 8m 28s
✔️ build-ansible-collection SUCCESS in 7m 15s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 04s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 04s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 15s
✔️ ansible-galaxy-importer SUCCESS in 3m 59s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit aa856e6 into ansible-collections:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants