Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_local_role: fix docs for vCenter #1678

Merged
merged 1 commit into from
Mar 17, 2023
Merged

vmware_local_role: fix docs for vCenter #1678

merged 1 commit into from
Mar 17, 2023

Conversation

p-fruck
Copy link
Contributor

@p-fruck p-fruck commented Mar 15, 2023

SUMMARY

Other than implied by documentation, the vmware_local_role info and manager modules also work with vCenter.
The documentation has been updated accordingly.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vmware_local_role_info
vmware_local_role_manager

ADDITIONAL INFORMATION

Tested on vCenter 7.0 U3

@p-fruck
vmware_local_role: fix docs for vCenter
780beb0 
Other than implied by documentation, these modules
actually also work with vCenter.
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d288655e1d96449a9e1eb9e00374781e

✔️ ansible-tox-linters SUCCESS in 8m 28s
✔️ build-ansible-collection SUCCESS in 9m 24s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 50s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 43s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 38s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 7m 22s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 49s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 FAILURE in 17m 27s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 25s

@p-fruck
Copy link
Contributor Author

p-fruck commented Mar 16, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/464f423ab93b4b3dac458b2290aa4658

✔️ ansible-tox-linters SUCCESS in 8m 23s
✔️ build-ansible-collection SUCCESS in 9m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 34s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 40s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 46s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 19s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 45s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 22m 05s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 34s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 54m 22s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 1h 01m 00s
✔️ ansible-galaxy-importer SUCCESS in 4m 18s

mariolenz
mariolenz approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @p-fruck!

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c4c1e7a452ea4cc8ae97cdfc03127ca9

✔️ ansible-tox-linters SUCCESS in 8m 16s
✔️ build-ansible-collection SUCCESS in 7m 16s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 13s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 46s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 21s
✔️ ansible-galaxy-importer SUCCESS in 4m 14s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0f8d9a7 into ansible-collections:main Mar 17, 2023
@mariolenz mariolenz mentioned this pull request Mar 22, 2023
Closed
@p-fruck p-fruck mentioned this pull request Apr 5, 2023
Merged
@mariolenz mariolenz mentioned this pull request May 10, 2023
Closed
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 17, 2023
@p-fruck
docs(vmware_object_role_permission): Clarify vCenter compatibility (#…
aa856e6 
…1705)

docs(vmware_object_role_permission): Clarify vCenter compatibility

SUMMARY

This update to the documentation should clarify that the module is compatible with ESXi and vCenter which previously wasn't clear by reading through the module description.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

vmware_object_role_permission and vmware_object_role_permission_info
ADDITIONAL INFORMATION


This PR is similar to #1678

Reviewed-by: Mario Lenz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-fruck @mariolenz