vmware_content_deploy_ovf_template does not respet resource_pool parameter #1290

Pigi-102 · 2022-04-15T13:24:47Z

SUMMARY

When creating a VM from an OVF template in a Content Library, no matter what resource_pool you try to configure ( either it does exist or not ) the VM get created in the top level resource pool ( if such thing exist ).

ISSUE TYPE

Bug Report

COMPONENT NAME

vmware_content_deploy_ovf_template

ANSIBLE VERSION

ansible --version
ansible 2.9.20
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/pigi/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib64/python3.9/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.9.10 (main, Jan 16 2022, 02:41:55) [GCC 11.2.0]

COLLECTION VERSION

CONFIGURATION

OS / ENVIRONMENT

STEPS TO REPRODUCE

Have a vmware environment with some resource pools.
Create a Content Library and upload an ovf
Try to create a VM from this ovf in a specific resource pool

- name: CreateBootStrap
  user: root
  hosts: localhost
  #become: true
  gather_facts: false
  vars:
# Define your username and password here that you want to create on target hosts.
    vcenter_hostname: vcsa67
    vcenter_username: pigi
    vcenter_password: Passw0rd
    OCP_template: rhcos-vmware.x86_64
    OCP_Library: Lib_CL_RHCOS
    Cluster: "Compute LAB Cluster"
    DataStore: Compute_03-Sistemi
    folderVM: "Pigi_folder_vm"
    DataCenter: "LAB Datacenter"
    NameVM:  "Test_for_OCP"
    ResPool: "OCP_TST"

   - name: create  machine from template. 
      community.vmware.vmware_content_deploy_ovf_template:
        cluster: '{{ Cluster }}'
        hostname: '{{ vcenter_hostname }}'
        username: '{{ vcenter_username }}'
        password: '{{ vcenter_password }}'
        template: '{{ OCP_template }}'
        content_library:  '{{ OCP_Library }}'
        datastore: '{{ DataStore }}'
        folder: '{{ folderVM }}'
        datacenter: '{{ DataCenter }}'
        name: '{{ NameVM }}'
        resource_pool: '{{ ResPool }}'
        storage_provisioning: thin
        validate_certs: no 
      delegate_to: localhost

EXPECTED RESULTS

I expepct that the VM would be created in the OCP_TST resource pool

ACTUAL RESULTS

The VM get created in the correct cluster but outside the resource pool

The text was updated successfully, but these errors were encountered:

Udayendu · 2022-06-10T05:32:39Z

This bug is still available in the latest version of vmware ansible collections.
Its taking the resource_pool value but there is no code to handle it.

Issue seems to be in

community.vmware/plugins/modules/vmware_content_deploy_template.py

Line 283 in 5326613

    
           self._resourcepool_id = self.get_resource_pool_by_name(self.datacenter, self.resourcepool, self.cluster, self.host)

line. Its trying to get the resource pool details using get_resource_pool_by_name function. But that function itself is not available. Hence no activity is happening at that lebel.

My installed version of collection:

$ ansible-galaxy collection list community.vmware

# /usr/local/lib/python3.8/dist-packages/ansible_collections
Collection       Version
---------------- -------
community.vmware 1.18.0

Can we get this fixed ?

mariolenz · 2022-06-11T15:28:54Z

@Udayendu This issue is about the vmware_content_deploy_ovf_template module. But you're linking to the vmware_content_deploy_template:

Issue seems to be in

community.vmware/plugins/modules/vmware_content_deploy_template.py

Line 283 in 5326613

self._resourcepool_id = self.get_resource_pool_by_name(self.datacenter, self.resourcepool, self.cluster, self.host)

Do you run into this issue with vmware_content_deploy_ovf_template, with vmware_content_deploy_template or with both?

Its trying to get the resource pool details using get_resource_pool_by_name function. But that function itself is not available. Hence no activity is happening at that lebel.

I think you're wrong there. You see, if this method wouldn't be available I think the module would crash. And, anyway, the method is defined in VmwareRestClient from where VmwareContentDeployTemplate inherits it:

community.vmware/plugins/module_utils/vmware_rest_client.py

Lines 370 to 375 in 1f295a8

    
               def get_resource_pool_by_name(self, datacenter_name, resourcepool_name, cluster_name=None, host_name=None): 
        
                   """ 
        
                   Returns the identifier of a resource pool 
        
                   with the mentioned names. 
        
                   """ 
        
                   datacenter = self.get_datacenter_by_name(datacenter_name)

mariolenz · 2022-06-11T15:29:21Z

@Pigi-102 It looks like the module searches for the resource pool only if both cluster and host are defined:

community.vmware/plugins/modules/vmware_content_deploy_ovf_template.py

Lines 262 to 264 in 1f295a8

    
           # Find the resourcepool by the given resourcepool name 
        
           if self.resourcepool and self.cluster and self.host: 
        
               self._resourcepool_id = self.get_resource_pool_by_name(self.datacenter, self.resourcepool, self.cluster, self.host)

Could you please try to deploy to a specific host in the cluster? I'd like to see what happens in this case. It would help me to fix this.

mariolenz · 2022-06-11T15:30:11Z

@n3pjk Could you have a look at this? You've been the last one to work on this module, so I thought you might be interested.

n3pjk · 2022-06-11T20:40:21Z

Sure thing! I don't use resource pools since they're evil, but I'll have a look. Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Mario Lenz ***@***.***> Sent: Saturday, June 11, 2022 11:30:22 AM To: ansible-collections/community.vmware ***@***.***> Cc: Paul Knight ***@***.***>; Mention ***@***.***> Subject: Re: [ansible-collections/community.vmware] vmware_content_deploy_ovf_template does not respet resource_pool parameter (Issue #1290) @n3pjk<https://github.com/n3pjk> Could you have a look at this? You've been the last one to work on this module, so I thought you might be interested. — Reply to this email directly, view it on GitHub<#1290 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA2LV6YAXZMZ5HAOO6EB5V3VOSWI5ANCNFSM5TQOIZMQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Pigi-102 · 2022-06-13T06:45:55Z

@Pigi-102 It looks like the module searches for the resource pool only if both cluster and host are defined:

community.vmware/plugins/modules/vmware_content_deploy_ovf_template.py

Lines 262 to 264 in 1f295a8

# Find the resourcepool by the given resourcepool name

if self.resourcepool and self.cluster and self.host:

self._resourcepool_id = self.get_resource_pool_by_name(self.datacenter, self.resourcepool, self.cluster, self.host)

Could you please try to deploy to a specific host in the cluster? I'd like to see what happens in this case. It would help me to fix this.

Hello,
unfortunally at the moment I don't have access to an infrastructure to execute the test.
In case I will gain a new access I will try it.
Sorry.

Udayendu · 2022-06-14T04:34:22Z

@mariolenz,

Issue is with both the modules. As this bug was already opened, so I though I should include it here.
But if you want I can open another bug for vmware_content_deploy_template and map it here as patch should go to both the tools separately.

mariolenz · 2022-06-14T09:38:22Z

Issue is with both the modules. As this bug was already opened, so I though I should include it here. But if you want I can open another bug for vmware_content_deploy_template and map it here as patch should go to both the tools separately.

@Udayendu I don't think that's necessary. Let's track both issues here. It's possibly the same basic problem because vmware_content_deploy_template also searches for the resource pool only if both cluster and host are defined

community.vmware/plugins/modules/vmware_content_deploy_template.py

Lines 281 to 283 in 1f295a8

    
           # Find the resourcepool by the given resourcepool name 
        
           if self.resourcepool and self.cluster and self.host: 
        
               self._resourcepool_id = self.get_resource_pool_by_name(self.datacenter, self.resourcepool, self.cluster, self.host)

Could you please specify both host and cluster in addition to resource_pool? If this works, I think we've already found the problem.

Udayendu · 2022-06-17T12:27:02Z

Issue is with both the modules. As this bug was already opened, so I though I should include it here. But if you want I can open another bug for vmware_content_deploy_template and map it here as patch should go to both the tools separately.

@Udayendu I don't think that's necessary. Let's track both issues here. It's possibly the same basic problem because vmware_content_deploy_template also searches for the resource pool only if both cluster and host are defined

community.vmware/plugins/modules/vmware_content_deploy_template.py

Lines 281 to 283 in 1f295a8

# Find the resourcepool by the given resourcepool name

if self.resourcepool and self.cluster and self.host:

self._resourcepool_id = self.get_resource_pool_by_name(self.datacenter, self.resourcepool, self.cluster, self.host)

Could you please specify both host and cluster in addition to resource_pool? If this works, I think we've already found the problem.

So far I was just using the cluster & resource_pool. Never tried to use the host as cluster supposed to do that selection. But I will try and update you by Monday.

Udayendu · 2022-06-20T05:57:18Z

@mariolenz
I have completed the testing and here is my observation:

Its able to deploy the vm under resource pool if cluster, resource pool and esxi hosts are selected at a time.
ESXi server should be 6.7 and higher. Initial I tried on couple of ESXi 6.5 hosts and it failed with a compatibility error message.

n3pjk · 2022-06-20T17:26:33Z

I see the problem. In both modules, cluster and host are in the if clause. I think removing them from the clause should correct the problem. I will submit a PR later today. Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Udayendu Kar ***@***.***> Sent: Monday, June 20, 2022 1:57:29 AM To: ansible-collections/community.vmware ***@***.***> Cc: Paul Knight ***@***.***>; Mention ***@***.***> Subject: Re: [ansible-collections/community.vmware] vmware_content_deploy_ovf_template does not respet resource_pool parameter (Issue #1290) @mariolenz<https://github.com/mariolenz> I have completed the testing and here is my observation: * Its able to deploy the vm under resource pool if cluster, resource pool and esxi hosts are selected at a time. * ESXi server should be 6.7 and higher. Initial I tried on couple of ESXi 6.5 hosts and it failed with a compatibility error message. — Reply to this email directly, view it on GitHub<#1290 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA2LV67FVMCNNNBQ5OE3YT3VQAB4TANCNFSM5TQOIZMQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

n3pjk · 2022-06-22T18:19:03Z

@Udayendu and @Pigi-102 - please check if PR #1362 resolves your issues. I have corrected the same behavior in both modules. Zuul passed the PR, thanks @mariolenz! Let me know if you still have issues.

Udayendu · 2022-06-23T11:51:19Z

@Udayendu and @Pigi-102 - please check if PR #1362 resolves your issues. I have corrected the same behavior in both modules. Zuul passed the PR, thanks @mariolenz! Let me know if you still have issues.

@n3pjk
Sure. I will check and get back to you in next couple of days.

Udayendu · 2022-06-23T12:39:55Z

@n3pjk, this patch fixed the issue in both the modules.
You can GA this and close this bug.

Thanks for the quick fix :)

ISSUE-1290 Remove cluster host fm Pools SUMMARY Fixes #1290 The two template deployment modules both require cluster and host when attempting to identify a resource pool. I have removed that constraint, as the lookup function defaults cluster and host to None if not provided. ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_content_deploy_ovf_template vmware_content_deploy_template ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]>

Backport PR #1362 to stable-1 SUMMARY Backport PR #1362 to stable-1 ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_content_deploy_ovf_template vmware_content_deploy_template ADDITIONAL INFORMATION #1290

n3pjk mentioned this issue Jun 22, 2022

ISSUE-1290 Remove cluster host fm Pools #1362

Merged

softwarefactory-project-zuul bot closed this as completed in #1362 Jun 23, 2022

mariolenz mentioned this issue Jun 23, 2022

Backport PR #1362 to stable-1 #1367

Merged

slauger mentioned this issue Jul 11, 2022

fix(deps): update galaxy-collection dependency community.vmware to v2 - autoclosed slauger/openshift-sdk#56

Closed

1 task

slauger mentioned this issue Oct 11, 2022

fix(deps): update galaxy-collection dependency community.vmware to v3 - autoclosed slauger/openshift-sdk#60

Closed

1 task

slauger mentioned this issue Oct 24, 2022

fix(deps): update galaxy-collection dependency community.vmware to v3 - autoclosed slauger/openshift-sdk#68

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vmware_content_deploy_ovf_template does not respet resource_pool parameter #1290

vmware_content_deploy_ovf_template does not respet resource_pool parameter #1290

Pigi-102 commented Apr 15, 2022

Udayendu commented Jun 10, 2022 •

edited

Loading

mariolenz commented Jun 11, 2022

mariolenz commented Jun 11, 2022 •

edited

Loading

mariolenz commented Jun 11, 2022

n3pjk commented Jun 11, 2022 via email

Pigi-102 commented Jun 13, 2022

Udayendu commented Jun 14, 2022

mariolenz commented Jun 14, 2022

Udayendu commented Jun 17, 2022 •

edited

Loading

Udayendu commented Jun 20, 2022

n3pjk commented Jun 20, 2022 via email

n3pjk commented Jun 22, 2022

Udayendu commented Jun 23, 2022

Udayendu commented Jun 23, 2022

vmware_content_deploy_ovf_template does not respet resource_pool parameter #1290

vmware_content_deploy_ovf_template does not respet resource_pool parameter #1290

Comments

Pigi-102 commented Apr 15, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

COLLECTION VERSION

CONFIGURATION

OS / ENVIRONMENT

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

Udayendu commented Jun 10, 2022 • edited Loading

mariolenz commented Jun 11, 2022

mariolenz commented Jun 11, 2022 • edited Loading

mariolenz commented Jun 11, 2022

n3pjk commented Jun 11, 2022 via email

Pigi-102 commented Jun 13, 2022

Udayendu commented Jun 14, 2022

mariolenz commented Jun 14, 2022

Udayendu commented Jun 17, 2022 • edited Loading

Udayendu commented Jun 20, 2022

n3pjk commented Jun 20, 2022 via email

n3pjk commented Jun 22, 2022

Udayendu commented Jun 23, 2022

Udayendu commented Jun 23, 2022

Udayendu commented Jun 10, 2022 •

edited

Loading

mariolenz commented Jun 11, 2022 •

edited

Loading

Udayendu commented Jun 17, 2022 •

edited

Loading