Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system logging API paths #127

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Conversation

therfert
Copy link
Contributor

SUMMARY

Adding API paths support:

  • system logging
  • system logging action

(fixes #114 )

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_modify
  • api_info
ADDITIONAL INFORMATION

none

Tomas Herfert added 3 commits November 12, 2022 21:59
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #127 (b1e3834) into main (60427ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          28       28           
  Lines        3499     3499           
  Branches      619      619           
=======================================
  Hits         3064     3064           
  Misses        308      308           
  Partials      127      127           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.45% <ø> (ø)
units 87.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_api_data.py 95.91% <ø> (ø)
plugins/modules/api_info.py 89.23% <ø> (ø)
plugins/modules/api_modify.py 79.90% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Nov 12, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Signed-off-by: Tomas Herfert <herfik>
@therfert therfert marked this pull request as ready for review November 12, 2022 21:44
@therfert
Copy link
Contributor Author

The failed checks were caused by a network issue on github. I don't have permissions to re-run them.

@felixfontein felixfontein merged commit 29247fa into ansible-collections:main Nov 13, 2022
@felixfontein
Copy link
Collaborator

@therfert thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new paths
2 participants